<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/freimair/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/freimair">@freimair</a> <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a> This is what I found in the day of auditing.</p>
<p>I agree that some users pass in references that are not thread-safe, but fixing that requires a real design and implementation plan that is outside of the scope of my current work. I've outlined a potential solution in the <code>Future Work</code> section for anyone else who is interested or assigned to fix that technical debt.</p>
<p>Feel free to take this or trash it. I'm also happy to just close my open PR that fixes the persistence bug in <code>TempProposalStore</code>. The amount of overhead maintaining these patches for weeks isn't worth my time if they are known issues and we don't have the resources to fix them.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3690?email_source=notifications&email_token=AJFFTNWTACCCCYXCVENUNPTQVRP6FA5CNFSM4JRQIML2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEGPNQ#issuecomment-558393270">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNX4O4RXIRXJH24OTJLQVRP6FANCNFSM4JRQIMLQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTMZ3KEDPDX55IFKDLQVRP6FA5CNFSM4JRQIML2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEGPNQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3690?email_source=notifications\u0026email_token=AJFFTNWTACCCCYXCVENUNPTQVRP6FA5CNFSM4JRQIML2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEGPNQ#issuecomment-558393270",
"url": "https://github.com/bisq-network/bisq/pull/3690?email_source=notifications\u0026email_token=AJFFTNWTACCCCYXCVENUNPTQVRP6FA5CNFSM4JRQIML2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEGPNQ#issuecomment-558393270",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>