<p>This PR fixes Bisq's language tags so Java's locale class will correctly display the name of script and regional variants of languages. There were previously hard-coded hacks to correctly display the language names correctly, and this PR removes those hacks since they are now properly displayed by Java.</p>
<p>It's actually a common misunderstanding in software localization:</p>
<ul>
<li>The language's regional variant, which is often a country, is separated with a dash.</li>
<li>The user's country is separated with an underscore.</li>
</ul>
<p>For some people, the difference is subtle:<br>
"en-us" = American English<br>
"en_US" = generic English in USA<br>
"en-gb" = British English<br>
"en-gb_US" = British English in USA</p>
<p>But for other people, the difference is very important:<br>
"br" = Portugese<br>
"br-pt" = Brazilian Portugese<br>
"br-pt_JP" = Brazilian Portugese in Japan</p>
<p>In this case, to merge <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="530097860" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3714" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/3714/hovercard" href="https://github.com/bisq-network/bisq/pull/3714">#3714</a>, I need the following script variant:<br>
"zh" = Chinese<br>
"zh-hans" = Simplified Chinese<br>
"zh-hant" = Traditional Chinese</p>
<p>Needs testing!</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3716'>https://github.com/bisq-network/bisq/pull/3716</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix language tags so script and regional variants work correctly</li>
  <li>Adjust update_translations.sh language tags for script/regional variants</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3716/files#diff-0">core/src/main/java/bisq/core/locale/LanguageUtil.java</a>
    (22)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3716/files#diff-1">core/src/main/resources/i18n/displayStrings_pt-br.properties</a>
    (0)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3716/files#diff-2">core/src/main/resources/i18n/displayStrings_zh-hans.properties</a>
    (0)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3716/files#diff-3">core/update_translations.sh</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3716.patch'>https://github.com/bisq-network/bisq/pull/3716.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3716.diff'>https://github.com/bisq-network/bisq/pull/3716.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3716?email_source=notifications&email_token=AJFFTNTQSAZ55Q3XMNBZ2ZDQWB7WDA5CNFSM4JS2INZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4ZFKKQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWN6ZSL6MGC4OKFJYTQWB7WDANCNFSM4JS2INZQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUVUWWDAX3GVST65YDQWB7WDA5CNFSM4JS2INZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4ZFKKQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3716?email_source=notifications\u0026email_token=AJFFTNTQSAZ55Q3XMNBZ2ZDQWB7WDA5CNFSM4JS2INZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4ZFKKQ",
"url": "https://github.com/bisq-network/bisq/pull/3716?email_source=notifications\u0026email_token=AJFFTNTQSAZ55Q3XMNBZ2ZDQWB7WDA5CNFSM4JS2INZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4ZFKKQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>