<p><b>@m52go</b> commented on this pull request.</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/RiccardoMasutti/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/RiccardoMasutti">@RiccardoMasutti</a> some final feedback. Mostly little things, along with a couple of questions that could use your advice/guidance.</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r353023192">_layouts/default.html</a>:</p>
<pre style='color:#555'>> @@ -63,6 +63,54 @@
<script defer src="/js/bootstrap.min.js"></script>
<script defer src="/js/scripts.js"></script>
+ <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+ <script type='application/ld+json'>
+ {
+ "@context": "https://schema.org/",
+ "@type": "SoftwareApplication",
+ "applicationCategory": "FinanceApplication",
+ "name": "Bisq",
</pre>
⬇️ Suggested change
<pre style="color: #555">- "name": "Bisq",
+ "name": "Bisq Network",
</pre>
<p>Full name...also better differentiates from new <code>author</code> name "Bisq" (see below).</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r353023250">_layouts/default.html</a>:</p>
<pre style='color:#555'>> @@ -63,6 +63,54 @@
<script defer src="/js/bootstrap.min.js"></script>
<script defer src="/js/scripts.js"></script>
+ <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+ <script type='application/ld+json'>
+ {
+ "@context": "https://schema.org/",
+ "@type": "SoftwareApplication",
+ "applicationCategory": "FinanceApplication",
+ "name": "Bisq",
+ "image": "https://bisq.network/images/bisq-logo.svg",
+ "availableOnDevice": "Desktop",
+ "author": {
+ "@type": "Project",
+ "url": "https://bisq.network/dao/",
</pre>
⬇️ Suggested change
<pre style="color: #555">- "url": "https://bisq.network/dao/",
+ "url": "https://bisq.network/",
</pre>
<p>See reasoning in comment below about referring to the author as Bisq instead of the Bisq DAO.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r353023279">_layouts/default.html</a>:</p>
<pre style='color:#555'>> @@ -63,6 +63,54 @@
<script defer src="/js/bootstrap.min.js"></script>
<script defer src="/js/scripts.js"></script>
+ <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+ <script type='application/ld+json'>
+ {
+ "@context": "https://schema.org/",
+ "@type": "SoftwareApplication",
+ "applicationCategory": "FinanceApplication",
+ "name": "Bisq",
+ "image": "https://bisq.network/images/bisq-logo.svg",
+ "availableOnDevice": "Desktop",
+ "author": {
+ "@type": "Project",
+ "url": "https://bisq.network/dao/",
+ "name": "Bisq Decentralized Autonomous Organization",
</pre>
⬇️ Suggested change
<pre style="color: #555">- "name": "Bisq Decentralized Autonomous Organization",
+ "name": "Bisq",
</pre>
<p>You're technically correct about Bisq being a DAO, but we usually refer to the body of the project as "Bisq" instead of the "Bisq DAO". Best practical example: see copyright on website footer...it's just plain old "Bisq" :)</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r353023376">_layouts/default.html</a>:</p>
<pre style='color:#555'>> @@ -63,6 +63,54 @@
<script defer src="/js/bootstrap.min.js"></script>
<script defer src="/js/scripts.js"></script>
+ <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+ <script type='application/ld+json'>
+ {
+ "@context": "https://schema.org/",
+ "@type": "SoftwareApplication",
+ "applicationCategory": "FinanceApplication",
+ "name": "Bisq",
+ "image": "https://bisq.network/images/bisq-logo.svg",
+ "availableOnDevice": "Desktop",
+ "author": {
+ "@type": "Project",
+ "url": "https://bisq.network/dao/",
+ "name": "Bisq Decentralized Autonomous Organization",
+ "sameAs": [
</pre>
<p>Are you sure this <code>sameAs</code> block is best placed in the <code>author</code> block? Might it be better to put it in the top-level block?</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r353023415">_layouts/default.html</a>:</p>
<pre style='color:#555'>> + "https://bisq.network/slack-invite",
+ "https://bisq.community/",
+ "https://lists.bisq.network/listinfo/bisq-contrib",
+ "https://webchat.freenode.net/?channels=bisq",
+ "https://www.reddit.com/r/bisq",
+ "https://keybase.io/team/bisq"
+ ]
+ },
+ "downloadUrl": "https://bisq.network/downloads/",
+ "fileSize": "180MB",
+ "operatingSystem": [
+ "Windows",
+ "Linux",
+ "OSX"
+ ],
+ "releaseNotes": "https://github.com/bisq-network/bisq/releases",
</pre>
⬇️ Suggested change
<pre style="color: #555">- "releaseNotes": "https://github.com/bisq-network/bisq/releases",
+ "releaseNotes": "https://github.com/bisq-network/bisq/releases/latest",
</pre>
<p>Nit: specifying the latest release is a more direct link to the most current release notes.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r353023434">_layouts/default.html</a>:</p>
<pre style='color:#555'>> + "https://bisq.community/",
+ "https://lists.bisq.network/listinfo/bisq-contrib",
+ "https://webchat.freenode.net/?channels=bisq",
+ "https://www.reddit.com/r/bisq",
+ "https://keybase.io/team/bisq"
+ ]
+ },
+ "downloadUrl": "https://bisq.network/downloads/",
+ "fileSize": "180MB",
+ "operatingSystem": [
+ "Windows",
+ "Linux",
+ "OSX"
+ ],
+ "releaseNotes": "https://github.com/bisq-network/bisq/releases",
+ "screenshot": "https://bisq.network/images/bisq_screen0.svg",
</pre>
⬇️ Suggested change
<pre style="color: #555">- "screenshot": "https://bisq.network/images/bisq_screen0.svg",
+ "screenshot": "https://bisq.network/images/bisq_screen0.png",
</pre>
<p>This <a href="https://github.com/bisq-network/bisq-website/pull/304" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq-website/pull/304/hovercard">changed</a> since this PR was made.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r353023454">_layouts/default.html</a>:</p>
<pre style='color:#555'>> + ]
+ },
+ "downloadUrl": "https://bisq.network/downloads/",
+ "fileSize": "180MB",
+ "operatingSystem": [
+ "Windows",
+ "Linux",
+ "OSX"
+ ],
+ "releaseNotes": "https://github.com/bisq-network/bisq/releases",
+ "screenshot": "https://bisq.network/images/bisq_screen0.svg",
+ "softwareVersion": "{{ site.client_version }}",
+ "aggregateRating": {
+ "@type": "AggregateRating",
+ "ratingValue": "5",
+ "ratingCount": "20"
</pre>
⬇️ Suggested change
<pre style="color: #555">- "ratingCount": "20"
+ "ratingCount": "5"
</pre>
<p>Making <code>ratingCount</code> equal to 5 matches the five 5-star reviews here:<br>
<a href="https://www.facebook.com/pg/BisqExchange/reviews/" rel="nofollow">https://www.facebook.com/pg/BisqExchange/reviews/</a></p>
<p>This gives the numbers a solid basis in case Google ever decides to dispute these figures.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-website/pull/290?email_source=notifications&email_token=AJFFTNTUCMROY4QGUG6USY3QWYFUDA5CNFSM4JQBKNH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNWX4EY#pullrequestreview-325942803">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNW7R23KVZV4FRAFFP3QWYFUDANCNFSM4JQBKNHQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQD4ASQUIHRE5RFQZ3QWYFUDA5CNFSM4JQBKNH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNWX4EY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-website/pull/290?email_source=notifications\u0026email_token=AJFFTNTUCMROY4QGUG6USY3QWYFUDA5CNFSM4JQBKNH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNWX4EY#pullrequestreview-325942803",
"url": "https://github.com/bisq-network/bisq-website/pull/290?email_source=notifications\u0026email_token=AJFFTNTUCMROY4QGUG6USY3QWYFUDA5CNFSM4JQBKNH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNWX4EY#pullrequestreview-325942803",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>