<p><b>@ripcurlx</b> requested changes on this pull request.</p>

<p>NACK - <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/wiz/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/wiz">@wiz</a> Thanks for the changes. I don't remember anymore if there was a reason not to support country specific language files, but I don't see a reason why not to do it. Please see my comment regarding one missing change.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3714#discussion_r352497538">core/update_translations.sh</a>:</p>
<pre style='color:#555'>> @@ -12,11 +12,12 @@ mv "$translations/es.properties" "$i18n/displayStrings_es.properties"
 mv "$translations/ja.properties" "$i18n/displayStrings_ja.properties"
 mv "$translations/pt.properties" "$i18n/displayStrings_pt.properties"
 mv "$translations/ru.properties" "$i18n/displayStrings_ru.properties"
-mv "$translations/zh_CN.properties" "$i18n/displayStrings_zh.properties"
+mv "$translations/zh_CN.properties" "$i18n/displayStrings_zh-hans.properties"
+mv "$translations/zh_TW.properties" "$i18n/displayStrings_zh-hant.properties"
</pre>
<p>To support that you need to update also <code>tx pull -l de,el_GR,es,ja,pt,ru,zh_CN,vi,th_TH,fa,fr,pt_BR</code> to <code>tx pull -l de,el_GR,es,ja,pt,ru,zh_CN,zh_TW,vi,th_TH,fa,fr,pt_BR</code></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3714?email_source=notifications&email_token=AJFFTNX3WWEJ6KSG2B3FVULQWTKJ3A5CNFSM4JSZJJ5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNQN4TY#pullrequestreview-325115471">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTKIJDW5BMY2HIQEIDQWTKJ3ANCNFSM4JSZJJ5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWM7O6XX7EOR6V4SALQWTKJ3A5CNFSM4JSZJJ5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNQN4TY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3714?email_source=notifications\u0026email_token=AJFFTNX3WWEJ6KSG2B3FVULQWTKJ3A5CNFSM4JSZJJ5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNQN4TY#pullrequestreview-325115471",
"url": "https://github.com/bisq-network/bisq/pull/3714?email_source=notifications\u0026email_token=AJFFTNX3WWEJ6KSG2B3FVULQWTKJ3A5CNFSM4JSZJJ5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNQN4TY#pullrequestreview-325115471",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>