<p>Remove manual version number changes in favor of automatically using the commit hash and tags to identify the version. This should allow easier support when multiple versions are used internally or in the field.</p>
<p>Original discussion: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="529604978" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3707" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/3707/hovercard" href="https://github.com/bisq-network/bisq/issues/3707">#3707</a></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/devinbileck/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/devinbileck">@devinbileck</a><br>
I wonder if it would be beneficial to try to implement versioning based on git commit hash? For example: <a href="https://98elements.com/blog/automatic-versioning-of-java-applications-using-git-version-gradle-plugin/" rel="nofollow">https://98elements.com/blog/automatic-versioning-of-java-applications-using-git-version-gradle-plugin/</a></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/cbeams/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cbeams">@cbeams</a><br>
I'd very much like to go this route, and I actually implemented it in the (now archived) bisq-pricenode repository at one point. Have a look at <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq-pricenode/commit/64f51ee/hovercard" href="https://github.com/bisq-network/bisq-pricenode/commit/64f51ee">bisq-network/bisq-pricenode@<tt>64f51ee</tt></a>, which introduces Palantir's git-version Gradle plugin, and the subsequent <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq-pricenode/commit/26a0247/hovercard" href="https://github.com/bisq-network/bisq-pricenode/commit/26a0247">bisq-network/bisq-pricenode@<tt>26a0247</tt></a> which reverts it. The reasons for backing that change out had to do with the hosting provider I was using for my pricenode (Heroku) not being able to support the change. I am no longer hosting there, and I believe no one else is either. If we have anyone hosting seednodes or pricenodes, etc in a Git-based push-to-deploy workflow like Heroku's, we should validate that this change won't be a problem for them, but I doubt that anyone is working that way. /cc @bisq-network/seednode-operators, @bisq-network/pricenode-operators.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/3735?email_source=notifications&email_token=AJFFTNQA2NK4WBJ6X73LRRLQW2PHZA5CNFSM4JU4NIDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5YKDZQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRXFMJEK2AGSSFYUM3QW2PHZANCNFSM4JU4NIDA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXJVMA4EXEUR4XUGI3QW2PHZA5CNFSM4JU4NIDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5YKDZQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/3735?email_source=notifications\u0026email_token=AJFFTNQA2NK4WBJ6X73LRRLQW2PHZA5CNFSM4JU4NIDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5YKDZQ",
"url": "https://github.com/bisq-network/bisq/issues/3735?email_source=notifications\u0026email_token=AJFFTNQA2NK4WBJ6X73LRRLQW2PHZA5CNFSM4JU4NIDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5YKDZQ",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>