<blockquote>
<p>BUNDLE_OF_ENVELOPES looks deprecated so nothing should be scheduled on the executor, right?. What is the supported backwards-compatibility here and Is there a point to even keeping this code path around?</p>
</blockquote>
<p>yes, the capability "BUNDLE_OF_ENVELOPES" has been deprecated as we made it default with the forced update. So the feature is still there and active with current clients, but the capability is not required anymore.</p>
<blockquote>
<p>I tested v1.2.4 without this patch and don't see the threads increasing with simple disconnect/reconnect. Is there something I need to do to exercise the code path?</p>
</blockquote>
<p>The code path only gets triggered if the throttle limits get hit (defined in <a href="https://github.com/bisq-network/bisq/blob/037f1672ddbf4d9db4f919f1332942fe96102bbb/p2p/src/main/java/bisq/network/p2p/network/Connection.java#L193">https://github.com/bisq-network/bisq/blob/037f1672ddbf4d9db4f919f1332942fe96102bbb/p2p/src/main/java/bisq/network/p2p/network/Connection.java#L193</a>)</p>
<p>as said above, this stuff is hard to test. After initial tests I had either version run in production for days with a profiler attached...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3734?email_source=notifications&email_token=AJFFTNQN7NW7GN3ICHRKMVLQW3XS7A5CNFSM4JUXIHYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3HW7A#issuecomment-561412988">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQWBLXWJQJ4WXXTXDTQW3XS7ANCNFSM4JUXIHYA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTZBH62EVMVKJUSDY3QW3XS7A5CNFSM4JUXIHYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3HW7A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3734?email_source=notifications\u0026email_token=AJFFTNQN7NW7GN3ICHRKMVLQW3XS7A5CNFSM4JUXIHYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3HW7A#issuecomment-561412988",
"url": "https://github.com/bisq-network/bisq/pull/3734?email_source=notifications\u0026email_token=AJFFTNQN7NW7GN3ICHRKMVLQW3XS7A5CNFSM4JUXIHYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3HW7A#issuecomment-561412988",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>