<p><b>@bodymindarts</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3718#discussion_r353349567">Makefile</a>:</p>
<pre style='color:#555'>> +    # fails to bind to one of the listed block notification ports
+       echo exit 0 >> .localnet/bitcoind/blocknotify
+
+# Alias '.localnet' to 'localnet' so the target is discoverable in tab
+# completion
+localnet: .localnet
+
+# Deploy a complete localnet by running all required Bitcoin and Bisq
+# nodes, each in their own named screen window. If you are not a screen
+# user, you'll need to manually run each of the targets listed below
+# commands manually in a separate terminal or as background jobs.
+deploy: setup
+       # create a new screen session named 'localnet'
+       screen -dmS localnet
+       # deploy each node in its own named screen window
+       targets=('bitcoind' 'seednode' 'seednode2' 'alice' 'bob' 'mediator'); \
</pre>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/cbeams/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cbeams">@cbeams</a> thanks for your instructive commit messages!<br>
I understand your reasoning behind removing <code>build</code> from PHONY. I'm just wondering wether there is a better solution. Doing a clean-rebuild takes a very long time and is not practical for quick iteration cycles. Essentially the problem you have solved is a race condition. Couldn't we ensure somehow that the build runs just once before deploying the individual nodes. Perhaps running the individual nodes shouldn't depend on the setup/build commands. That way we could have both a 1 time setup + iteration.<br>
Is there a significant advantage of having all the individual node commands depend on setup/build that I'm missing?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3718?email_source=notifications&email_token=AJFFTNVH3LKV3IUJJLJ6F63QW2QV3A5CNFSM4JTEFEKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNZ5E6Y#discussion_r353349567">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVPHGALWTAVXXTQWNDQW2QV3ANCNFSM4JTEFEKA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNV7A3NIWOUVUFQHA7DQW2QV3A5CNFSM4JTEFEKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNZ5E6Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3718?email_source=notifications\u0026email_token=AJFFTNVH3LKV3IUJJLJ6F63QW2QV3A5CNFSM4JTEFEKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNZ5E6Y#discussion_r353349567",
"url": "https://github.com/bisq-network/bisq/pull/3718?email_source=notifications\u0026email_token=AJFFTNVH3LKV3IUJJLJ6F63QW2QV3A5CNFSM4JTEFEKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNZ5E6Y#discussion_r353349567",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>