<p><b>@julianknutsen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3747#discussion_r354965237">p2p/src/main/java/bisq/network/p2p/storage/payload/ProtectedMailboxStorageEntry.java</a>:</p>
<pre style='color:#555'>> @@ -107,7 +107,7 @@ public boolean isValidForAddOperation() {
         if (!result) {
             String res1 = this.toString();
             String res2 = "null";
-            if (mailboxStoragePayload != null && mailboxStoragePayload.getOwnerPubKey() != null)
+            if (mailboxStoragePayload.getOwnerPubKey() != null)
</pre>
<p>I could have been more clear with the distinction. Here is the relevant code for the payload itself. Since it is a submessage in proto3 it can technically be null, but the resolver handles those cases and raises an exception:</p>
<p><a href="https://github.com/bisq-network/bisq/blob/76e8c5736a6c5f56cca83323c373d2f3eb3f2542/core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java#L249-L278">https://github.com/bisq-network/bisq/blob/76e8c5736a6c5f56cca83323c373d2f3eb3f2542/core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java#L249-L278</a></p>
<p>The other non-null issues were due to the initialized value for proto3 not being null, this isn't one of those cases.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3747?email_source=notifications&email_token=AJFFTNQGHWWIU5WTHU2JUVLQXKJFVA5CNFSM4JVOFKAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOJJF5I#discussion_r354965237">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTYWKGC5SHSPZ35HB3QXKJFVANCNFSM4JVOFKAA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXXVNGBDGA7D6JPDDTQXKJFVA5CNFSM4JVOFKAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOJJF5I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3747?email_source=notifications\u0026email_token=AJFFTNQGHWWIU5WTHU2JUVLQXKJFVA5CNFSM4JVOFKAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOJJF5I#discussion_r354965237",
"url": "https://github.com/bisq-network/bisq/pull/3747?email_source=notifications\u0026email_token=AJFFTNQGHWWIU5WTHU2JUVLQXKJFVA5CNFSM4JVOFKAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOJJF5I#discussion_r354965237",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>