<p><b>@julianknutsen</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3747#discussion_r355574642">p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java</a>:</p>
<pre style='color:#555'>> - Utilities.toTruncatedString(toRemoveItem.getValue()));
- });
- removeFromMapAndDataStore(toRemoveList);
-
- if (sequenceNumberMap.size() > this.maxSequenceNumberMapSizeBeforePurge)
- sequenceNumberMap.setMap(getPurgedSequenceNumberMap(sequenceNumberMap.getMap()));
+ // Backdate all the eligible payloads based on the node that disconnected
+ map.values().stream()
+ .filter(protectedStorageEntry -> protectedStorageEntry.getProtectedStoragePayload() instanceof ExpirablePayload)
+ .filter(protectedStorageEntry -> protectedStorageEntry.getProtectedStoragePayload() instanceof RequiresOwnerIsOnlinePayload)
+ .filter(protectedStorageEntry -> ((RequiresOwnerIsOnlinePayload) protectedStorageEntry.getProtectedStoragePayload()).getOwnerNodeAddress().equals(peersNodeAddress))
+ .forEach(protectedStorageEntry -> {
+ // We only set the data back by half of the TTL and remove the data only if is has
+ // expired after that back dating.
+ // We might get connection drops which are not caused by the node going offline, so
+ // we give more tolerance with that approach, giving the node the change to
</pre>
<p>Addressed in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/e8c822563572671d32743d0e70fd89274c7db6ca/hovercard" href="https://github.com/bisq-network/bisq/commit/e8c822563572671d32743d0e70fd89274c7db6ca"><tt>e8c8225</tt></a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3747?email_source=notifications&email_token=AJFFTNQD3FVOPCW4YTEUO3TQXZ4G3A5CNFSM4JVOFKAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOOWI3Y#discussion_r355574642">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUDXXGDQVSTG4U4A2DQXZ4G3ANCNFSM4JVOFKAA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRWOGERSPYKERZFGIDQXZ4G3A5CNFSM4JVOFKAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOOWI3Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3747?email_source=notifications\u0026email_token=AJFFTNQD3FVOPCW4YTEUO3TQXZ4G3A5CNFSM4JVOFKAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOOWI3Y#discussion_r355574642",
"url": "https://github.com/bisq-network/bisq/pull/3747?email_source=notifications\u0026email_token=AJFFTNQD3FVOPCW4YTEUO3TQXZ4G3A5CNFSM4JVOFKAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOOWI3Y#discussion_r355574642",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>