<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #1952.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="383680410" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/1952" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/1952/hovercard" href="https://github.com/bisq-network/bisq/issues/1952">#1952</a>.</p>
<p>In my role as Bisq desktop maintainer and release manager I applied for a personal code signing certificate for <code>DI(FH) Christoph Johann Atteneder</code> (yes they wanted all academic titles and names included) at Sectigo (former Comodo). I applied for a code signing certificate which will expire on December 10th 2020.</p>
<p><em>Verification steps</em><br>
To test the behavior of a signed Windows executable you'll actually need a Windows machine to do so.<br>
For testing purpose I've created a signed version of our Windows installer for v1.2.4.<br>
Executable: <a rel="nofollow" href="https://www.dropbox.com/s/ukrotb5neajgwwu/Bisq-1.2.4.exe?dl=0">https://www.dropbox.com/s/ukrotb5neajgwwu/Bisq-1.2.4.exe?dl=0</a><br>
Signature: <a rel="nofollow" href="https://www.dropbox.com/s/hasuwvch0lag7wx/Bisq-1.2.4.exe.asc?dl=0">https://www.dropbox.com/s/hasuwvch0lag7wx/Bisq-1.2.4.exe.asc?dl=0</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3772'>https://github.com/bisq-network/bisq/pull/3772</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add command for signing windows executables with the default code signing certificate</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3772/files#diff-0">desktop/package/windows/package.bat</a>
    (6)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3772.patch'>https://github.com/bisq-network/bisq/pull/3772.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3772.diff'>https://github.com/bisq-network/bisq/pull/3772.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3772?email_source=notifications&email_token=AJFFTNUFVZL7P2AQVMAB2E3QX5557A5CNFSM4JY5CLP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H7NXVTA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWYSOEVO7HQ432UL5LQX5557ANCNFSM4JY5CLPQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSQWJ2K2YJK3FWR4M3QX5557A5CNFSM4JY5CLP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H7NXVTA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3772?email_source=notifications\u0026email_token=AJFFTNUFVZL7P2AQVMAB2E3QX5557A5CNFSM4JY5CLP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H7NXVTA",
"url": "https://github.com/bisq-network/bisq/pull/3772?email_source=notifications\u0026email_token=AJFFTNUFVZL7P2AQVMAB2E3QX5557A5CNFSM4JY5CLP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H7NXVTA",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>