<p><b>@freimair</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3762#discussion_r356507905">CONTRIBUTING.md</a>:</p>
<pre style='color:#555'>>  
+**Tools?** If you want to develop code, we expect you to know your ways around Git and Java. Then comes testing, JavaFX, Gradle, Github, ... As for non-functional skills, we love to see people knowing their ways around P2P networks, cryptography, security, privacy, ...
</pre>
<blockquote>
<p>I expected a list of testing frameworks or patterns after the first three words.</p>
</blockquote>
<p>I intentionally left that open.</p>
<ul>
<li>keep the text easy to read</li>
<li>if a Java dev knows testing, we have already won. Testing (imo?) is not about a certain framework, testing is a philosophy. If there is a framework unknown to you, you just learn it (although JUnit can hardly be called unknown).</li>
<li>maybe some dev comes along with a special set of skills we did not know we want and need. Not being too specific leaves some room for such a dev to fit in</li>
</ul>
<p>Thoughts?</p>
<blockquote>
<p>The non-functional skills part doesn't seem to fit with Tools.</p>
</blockquote>
<p>Agreed. Didn't like that title either. "Skills"?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3762?email_source=notifications&email_token=AJFFTNUKGMIBPJ5MWY2HEKLQYC4G7A5CNFSM4JX3RI52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOY6YKY#discussion_r356507905">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQKANLSWB54X2BYNBLQYC4G7ANCNFSM4JX3RI5Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWPPLVBBWCGCPQP6MLQYC4G7A5CNFSM4JX3RI52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOY6YKY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3762?email_source=notifications\u0026email_token=AJFFTNUKGMIBPJ5MWY2HEKLQYC4G7A5CNFSM4JX3RI52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOY6YKY#discussion_r356507905",
"url": "https://github.com/bisq-network/bisq/pull/3762?email_source=notifications\u0026email_token=AJFFTNUKGMIBPJ5MWY2HEKLQYC4G7A5CNFSM4JX3RI52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOY6YKY#discussion_r356507905",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>