<p>This fixes the problem if the local bitcoin core node is not detected by our client,<br>
but bitcoinj is able to connect to it because of the auto connect to localhost behavior.<br>
In that case the minimum required nodes to broadcast a transaction will be 4 (provided nodes settings),<br>
but bitcoinj will only connect to one node. The requirement of 4 nodes will be never fulfilled and<br>
the transaction never broadcasted.</p>
<h3>Testinig</h3>
<p>As this is a bug based on the default localhost connect behavior of bitcoinj it is difficult to simulate on regtest.<br>
To simulate this behavior on mainnet you could try following steps:</p>
<ul>
<li>Use current master</li>
<li>Skip the initial check for a localhost node in BisqSetup <code>step 3</code></li>
<li>Go to network settings and you'll see only one node is connected but the minimum peers for broadcast is still set to <code>4</code></li>
<li>Checkout this PR and skip the initial check for localhost again</li>
<li>Go to network settings and you'll see that the client connects to the provided nodes and will be able to broadcast transactions</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3783'>https://github.com/bisq-network/bisq/pull/3783</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Not allow bitcoinj to auto connect to localhost when localhost was not detected by client</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3783/files#diff-0">core/src/main/java/bisq/core/btc/setup/WalletConfig.java</a>
    (6)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3783.patch'>https://github.com/bisq-network/bisq/pull/3783.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3783.diff'>https://github.com/bisq-network/bisq/pull/3783.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3783?email_source=notifications&email_token=AJFFTNVY5TFGJWPICY3AR5DQYJR4DA5CNFSM4J2BIZ52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IADJU3Q">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVMRMBBYNB22OOSKLDQYJR4DANCNFSM4J2BIZ5Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNX77RB2255DHNYWEGTQYJR4DA5CNFSM4J2BIZ52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IADJU3Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3783?email_source=notifications\u0026email_token=AJFFTNVY5TFGJWPICY3AR5DQYJR4DA5CNFSM4J2BIZ52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IADJU3Q",
"url": "https://github.com/bisq-network/bisq/pull/3783?email_source=notifications\u0026email_token=AJFFTNVY5TFGJWPICY3AR5DQYJR4DA5CNFSM4J2BIZ52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IADJU3Q",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>