<p><b>@devinbileck</b> requested changes on this pull request.</p>

<p>NACK.<br>
Based on my prior comment requiring validation during restore.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3044#discussion_r360616924">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -1073,6 +1073,15 @@ setting.preferences.dao.fullNodeInfo.cancel=No, I stick with lite node mode
 settings.net.btcHeader=Bitcoin network
 settings.net.p2pHeader=Bisq network
 settings.net.onionAddressLabel=My onion address
+settings.net.renewAddressButton=Create new address
+settings.net.renewAddress=Please be aware that you will loose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?
</pre>
⬇️ Suggested change
<pre style="color: #555">-settings.net.renewAddress=Please be aware that you will loose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?
+settings.net.renewAddress=Please be aware that you will lose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3044#discussion_r360617385">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -1073,6 +1073,15 @@ setting.preferences.dao.fullNodeInfo.cancel=No, I stick with lite node mode
 settings.net.btcHeader=Bitcoin network
 settings.net.p2pHeader=Bisq network
 settings.net.onionAddressLabel=My onion address
+settings.net.renewAddressButton=Create new address
+settings.net.renewAddress=Please be aware that you will loose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?
+settings.net.exportAddressButton=Backup address
+settings.net.exportAddressFileDialog=Select the backup file
+settings.net.exportAddressFileEnding=Bisq Onion Address Backup (*.bisq)
+settings.net.importAddressButton=Restore address
+settings.net.importAddressFileDialog=Select the backup file
+settings.net.importAddress=Please be aware that you will loose your reputation when you restore a previous onion address (but restore your reputation connected to the restored onion address). Furthermore, you need to restart the application to set your new onion address active.
</pre>
⬇️ Suggested change
<pre style="color: #555">-settings.net.importAddress=Please be aware that you will loose your reputation when you restore a previous onion address (but restore your reputation connected to the restored onion address). Furthermore, you need to restart the application to set your new onion address active.
+settings.net.importAddress=Please be aware that you will lose your reputation when you restore a previous onion address (but restore your reputation connected to the restored onion address). Furthermore, you need to restart the application to set your new onion address active.
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3044#discussion_r360618146">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -1073,6 +1073,15 @@ setting.preferences.dao.fullNodeInfo.cancel=No, I stick with lite node mode
 settings.net.btcHeader=Bitcoin network
 settings.net.p2pHeader=Bisq network
 settings.net.onionAddressLabel=My onion address
+settings.net.renewAddressButton=Create new address
+settings.net.renewAddress=Please be aware that you will loose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?
</pre>
<p>Perhaps we should emphasize the significance of this action. Although it wont remove the old address immediately if there are open offers/trades, they will not be able to back up the old address after creating a new address. So perhaps highly recommend that they backup prior to creating a new address if there are open trades/offers or perhaps even if there are closed trades (just in case).</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3044#discussion_r360618227">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -1073,6 +1073,15 @@ setting.preferences.dao.fullNodeInfo.cancel=No, I stick with lite node mode
 settings.net.btcHeader=Bitcoin network
 settings.net.p2pHeader=Bisq network
 settings.net.onionAddressLabel=My onion address
+settings.net.renewAddressButton=Create new address
+settings.net.renewAddress=Please be aware that you will loose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?
+settings.net.exportAddressButton=Backup address
+settings.net.exportAddressFileDialog=Select the backup file
+settings.net.exportAddressFileEnding=Bisq Onion Address Backup (*.bisq)
+settings.net.importAddressButton=Restore address
+settings.net.importAddressFileDialog=Select the backup file
+settings.net.importAddress=Please be aware that you will loose your reputation when you restore a previous onion address (but restore your reputation connected to the restored onion address). Furthermore, you need to restart the application to set your new onion address active.
</pre>
<p>As mentioned with renew address, perhaps we should emphasize the significance of this action as well.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3044?email_source=notifications&email_token=AJFFTNUHKXESGPIDE27OAHTQ2SLCTA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQAIACI#pullrequestreview-335577097">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNX343AFKW2TNJ265LTQ2SLCTANCNFSM4IIPXYQQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNV44KKA2R7UZMTV443Q2SLCTA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQAIACI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3044?email_source=notifications\u0026email_token=AJFFTNUHKXESGPIDE27OAHTQ2SLCTA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQAIACI#pullrequestreview-335577097",
"url": "https://github.com/bisq-network/bisq/pull/3044?email_source=notifications\u0026email_token=AJFFTNUHKXESGPIDE27OAHTQ2SLCTA5CNFSM4IIPXYQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQAIACI#pullrequestreview-335577097",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>