<p>This function didnt have terminating short circuit<br>
which is important for and operator functions.</p>
<p>Also this function gets called multiple times since it's validation function.<br>
hence improving needed here.</p>
<p>After verifying usages, left out following two classes</p>
<ol>
<li>PercentageNumberValidator - since it's using only two validation</li>
<li>PhoneNumberValidator - have variable inputs and this is only place.</li>
</ol>


<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3838'>https://github.com/bisq-network/bisq/pull/3838</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Refactoring of and function in ValidationResult class</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3838/files#diff-0">core/src/main/java/bisq/core/util/validation/InputValidator.java</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3838/files#diff-1">desktop/src/main/java/bisq/desktop/util/validation/BsqValidator.java</a>
    (18)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3838/files#diff-2">desktop/src/main/java/bisq/desktop/util/validation/BtcValidator.java</a>
    (15)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3838/files#diff-3">desktop/src/main/java/bisq/desktop/util/validation/MonetaryValidator.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3838/files#diff-4">desktop/src/main/java/bisq/desktop/util/validation/SecurityDepositValidator.java</a>
    (9)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3838.patch'>https://github.com/bisq-network/bisq/pull/3838.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3838.diff'>https://github.com/bisq-network/bisq/pull/3838.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3838?email_source=notifications&email_token=AJFFTNQZZMVTSQUB4Z5IM7DQ263O7A5CNFSM4KAR6OK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDBZATQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNS3MHTW46L2LWS6H5DQ263O7ANCNFSM4KAR6OKQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXAFCLSSFSGGI3HRV3Q263O7A5CNFSM4KAR6OK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDBZATQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3838?email_source=notifications\u0026email_token=AJFFTNQZZMVTSQUB4Z5IM7DQ263O7A5CNFSM4KAR6OK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDBZATQ",
"url": "https://github.com/bisq-network/bisq/pull/3838?email_source=notifications\u0026email_token=AJFFTNQZZMVTSQUB4Z5IM7DQ263O7A5CNFSM4KAR6OK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDBZATQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>