<p><b>@chimp1984</b> requested changes on this pull request.</p>

<p>NACK</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3837#discussion_r362147128">core/src/main/java/bisq/core/app/BisqExecutable.java</a>:</p>
<pre style='color:#555'>>  
-    public static boolean setupInitialOptionParser(String[] args) throws IOException {
+    public static boolean setupInitialOptionParser(String[] args, boolean isBisq) throws IOException {
</pre>
<p>isBisq ???? Sounds like a very non-intuitive param name</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3837#discussion_r362147286">core/src/main/java/bisq/core/app/BisqExecutable.java</a>:</p>
<pre style='color:#555'>>      private final String fullName;
     private final String scriptName;
     private final String version;
        
-       private final Preferences prefs;
+       private static Preferences prefs = Preferences.userRoot().node("Bisq");;
</pre>
<p>If you want to achieve the behaviour of first time app start, that is done in a different style in many placed. I don't htink its a good ide to introduce this new style and the context of node is weird to me.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3837?email_source=notifications&email_token=AJFFTNRLDFXAG44O3MCBNZ3Q3LDZBA5CNFSM4KARVN42YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQNLPKI#pullrequestreview-337295273">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTCL6S2PKAYGN4KTJTQ3LDZBANCNFSM4KARVN4Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNS4OKQUU5HOKZEYDSTQ3LDZBA5CNFSM4KARVN42YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQNLPKI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3837?email_source=notifications\u0026email_token=AJFFTNRLDFXAG44O3MCBNZ3Q3LDZBA5CNFSM4KARVN42YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQNLPKI#pullrequestreview-337295273",
"url": "https://github.com/bisq-network/bisq/pull/3837?email_source=notifications\u0026email_token=AJFFTNRLDFXAG44O3MCBNZ3Q3LDZBA5CNFSM4KARVN42YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQNLPKI#pullrequestreview-337295273",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>