<p>In the past we didn't give the user a hint if the minimum trading fee or minimum deposit was used.<br>
It was shown to the user during offer creation and gave especially new users the impression<br>
that Bisq has very high trading fees and requires a crazy amount for deposit in relation to the trading amount.</p>
<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #3868.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="546152406" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3868" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/3868/hovercard" href="https://github.com/bisq-network/bisq/issues/3868">#3868</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="532808438" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3746" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/3746/hovercard" href="https://github.com/bisq-network/bisq/issues/3746">#3746</a>.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3870'>https://github.com/bisq-network/bisq/pull/3870</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Use trading fee in BSQ fee comparison</li>
  <li>Add information if minimum trading fee or minimum security deposit is used</li>
  <li>Show minimum security deposit in create offer dialog when used</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3870/files#diff-0">core/src/main/resources/i18n/displayStrings.properties</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3870/files#diff-1">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3870/files#diff-2">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3870/files#diff-3">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java</a>
    (26)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3870/files#diff-4">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3870/files#diff-5">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java</a>
    (23)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3870/files#diff-6">desktop/src/main/java/bisq/desktop/util/GUIUtil.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3870/files#diff-7">desktop/src/test/java/bisq/desktop/util/GUIUtilTest.java</a>
    (36)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3870.patch'>https://github.com/bisq-network/bisq/pull/3870.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3870.diff'>https://github.com/bisq-network/bisq/pull/3870.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3870?email_source=notifications&email_token=AJFFTNUAX25JRJB6HQAYI4TQ4SVNRA5CNFSM4KD33GT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IERFFDQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUFZYTY3IFNWL36GHDQ4SVNRANCNFSM4KD33GTQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUMDAEAKOT3PWWRW4DQ4SVNRA5CNFSM4KD33GT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IERFFDQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3870?email_source=notifications\u0026email_token=AJFFTNUAX25JRJB6HQAYI4TQ4SVNRA5CNFSM4KD33GT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IERFFDQ",
"url": "https://github.com/bisq-network/bisq/pull/3870?email_source=notifications\u0026email_token=AJFFTNUAX25JRJB6HQAYI4TQ4SVNRA5CNFSM4KD33GT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IERFFDQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>