<p><b>@ripcurlx</b> requested changes on this pull request.</p>

<p>NACK - Because of code format issues. Please also rebase your PR against master so it is easier also to test with a mainnet client. Thanks!</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3785#discussion_r365844442">desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java</a>:</p>
<pre style='color:#555'>> +    TableColumn<ClosedTradableListItem, ClosedTradableListItem> priceColumn, amountColumn, volumeColumn, 
+               makerMiningFeeColumn, takerMiningFeeColumn, makerTradingFeeColumn, takerTradingFeeColumn, buyerSecurityDepositColumn, 
+               sellerSecurityDepositColumn, marketColumn, directionColumn, dateColumn, tradeIdColumn, stateColumn, avatarColumn;
+    
</pre>
<p>Nearly every line in this file except the imports has issues with using the wrong spacing (not using our format style)</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3785#discussion_r365845598">desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java</a>:</p>
<pre style='color:#555'>> @@ -20,11 +20,12 @@
 import bisq.desktop.common.model.ActivatableWithDataModel;
 import bisq.desktop.common.model.ViewModel;
 import bisq.desktop.util.DisplayUtils;
-
+import bisq.common.crypto.KeyRing;
</pre>
<p>Empty line is missing before and after this import to be in line with our imports format</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3785#discussion_r365845862">desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java</a>:</p>
<pre style='color:#555'>> @@ -126,7 +142,22 @@ String getSellerSecurityDeposit(ClosedTradableListItem item) {
         else
             return "";
     }
-
+    
</pre>
<p>Unnecessary spaces</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3785#discussion_r365846195">desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java</a>:</p>
<pre style='color:#555'>> +        }
+        else {
+            return "";
+        }
+    }
+    
</pre>
<p>Format issues as well. Please apply our code format style.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3785?email_source=notifications&email_token=AJFFTNVJYNGNL42JC2RSZDTQ5R6DFA5CNFSM4J2GDL6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRQPBGY#pullrequestreview-341897371">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRFFQJ4P7QAL5QR2K3Q5R6DFANCNFSM4J2GDL6A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNW3RQMPDFVCMARLOADQ5R6DFA5CNFSM4J2GDL6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRQPBGY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3785?email_source=notifications\u0026email_token=AJFFTNVJYNGNL42JC2RSZDTQ5R6DFA5CNFSM4J2GDL6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRQPBGY#pullrequestreview-341897371",
"url": "https://github.com/bisq-network/bisq/pull/3785?email_source=notifications\u0026email_token=AJFFTNVJYNGNL42JC2RSZDTQ5R6DFA5CNFSM4J2GDL6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRQPBGY#pullrequestreview-341897371",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>