<p><b>@cbeams</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3889#discussion_r368471458">gradle/witness/gradle-witness.gradle</a>:</p>
<pre style='color:#555'>> +        'io.opencensus:opencensus-api:8e2cb0f6391d8eb0a1bcd01e7748883f0033b1941754f4ed3f19d2c3e4276fc8',
+        'io.opencensus:opencensus-contrib-grpc-metrics:29fc79401082301542cab89d7054d2f0825f184492654c950020553ef4ff0ef8',
+        'io.opencensus:opencensus-contrib-http-util:d62fd27175a842bde135f6f6b1d6f25d42e9bd59a87bc98709a4760fe399ee14',
+        'io.perfmark:perfmark-api:b734ba2149712409a44eabdb799f64768578fee0defe1418bb108fe32ea43e1a',
</pre>
<p>Good catch. Some of these and a number of other dependencies are removed in <a href="https://github.com/cbeams/bisq/commit/85781a23d0abcba169ec8aa7d6d409741c0ac5df">a commit that currently exists only in my fork's grpc-api branch</a>. These changes were made as part of further refactorings of <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a>'s original PoC, and it was an oversight that I didn't include them here. It will require some rework of that commit to do so, but is probably worth it to make sure we don't ship a release that includes these deps, even if they will be removed soon thereafter. I'll push that additional commit as soon as possible. Though note that I'll probably push it against the <code>grpc-poc</code> branch (PR <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="548269504" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3888" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/3888/hovercard" href="https://github.com/bisq-network/bisq/pull/3888">#3888</a>), as it's really part of that change as opposed to this one.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3889?email_source=notifications&email_token=AJFFTNVIAKB4T3UR4MW3TYTQ6V3ZJA5CNFSM4KFNLJBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSJXUHQ#discussion_r368471458">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNV76Z462EBZ5MEMXVTQ6V3ZJANCNFSM4KFNLJBA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNU3J54RQRS42IK3OFTQ6V3ZJA5CNFSM4KFNLJBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSJXUHQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3889?email_source=notifications\u0026email_token=AJFFTNVIAKB4T3UR4MW3TYTQ6V3ZJA5CNFSM4KFNLJBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSJXUHQ#discussion_r368471458",
"url": "https://github.com/bisq-network/bisq/pull/3889?email_source=notifications\u0026email_token=AJFFTNVIAKB4T3UR4MW3TYTQ6V3ZJA5CNFSM4KFNLJBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSJXUHQ#discussion_r368471458",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>