<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ripcurlx/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a> re: <a href="https://github.com/bisq-network/bisq/pull/3889#pullrequestreview-345220708" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/3889/hovercard">#3889 (review)</a>, this is also regarding <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="548269504" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3888" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/3888/hovercard" href="https://github.com/bisq-network/bisq/pull/3888">#3888</a>. To be clear, can you re-iterate that your ACK is for the changes specific to this PR, i.e. all things <code>Config</code> and related to option handling?</p>
</blockquote>
<p>Actually for both - So I read through all the changes regarding <code>Config</code> changes and it worked for my local setup. Regarding the remarks in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="548269504" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3888" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/3888/hovercard" href="https://github.com/bisq-network/bisq/pull/3888">#3888</a>: I didn't run the code before, just reviewed the changes, so I checked this time the GRPC prototype in my local setup as well.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3889?email_source=notifications&email_token=AJFFTNXIFC2XULVGDWQEE7DQ6WDGTA5CNFSM4KFNLJBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJMJ3CI#issuecomment-576232841">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUY77CETA4XWSS2V4LQ6WDGTANCNFSM4KFNLJBA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQ75F4UZTOKL2MKN3TQ6WDGTA5CNFSM4KFNLJBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJMJ3CI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3889?email_source=notifications\u0026email_token=AJFFTNXIFC2XULVGDWQEE7DQ6WDGTA5CNFSM4KFNLJBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJMJ3CI#issuecomment-576232841",
"url": "https://github.com/bisq-network/bisq/pull/3889?email_source=notifications\u0026email_token=AJFFTNXIFC2XULVGDWQEE7DQ6WDGTA5CNFSM4KFNLJBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJMJ3CI#issuecomment-576232841",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>