<blockquote>
<p>Avoiding duplicate trade stats is good but is it really a breaking issue? Perhaps any duplicates should be removed if they have a deposittxid set for trades made after the cutoff date.</p>
<p>Seed nodes would be upgraded by the cutoff date and only a few users would still be running on version < 1.2.5. They might have duplicate entries but I don't think that would cause harm and once they upgrade they would also remove the bad duplicates. I think it's good to avoid forced upgrades as much as possible.</p>
</blockquote>
<p>True, that could be done. I'll have a look on how to clean up duplicates in that case.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3911?email_source=notifications&email_token=AJFFTNUXFPISPBLHRXWAQDLRAFZJXA5CNFSM4KJVYNTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHAZQY#issuecomment-579734723">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSSEJ5RTT7G3MWEOMTRAFZJXANCNFSM4KJVYNTA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXPO67GXMQA7LD7PT3RAFZJXA5CNFSM4KJVYNTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHAZQY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3911?email_source=notifications\u0026email_token=AJFFTNUXFPISPBLHRXWAQDLRAFZJXA5CNFSM4KJVYNTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHAZQY#issuecomment-579734723",
"url": "https://github.com/bisq-network/bisq/pull/3911?email_source=notifications\u0026email_token=AJFFTNUXFPISPBLHRXWAQDLRAFZJXA5CNFSM4KJVYNTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHAZQY#issuecomment-579734723",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>