<p>As it doesn't give more privacy to set deposit transaction ids of old trade statistics to null (can be retrieved by data stores of old client binaries) and only would cause additional load for our seednodes I've reverted this change. Still as old clients will parse null to an empty string causes them to load trades by new clients (v1.2.6) to reload on restart as empty string != null.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3933?email_source=notifications&email_token=AJFFTNQSJZ6NHV5ELDRSUQTRBAVARA5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUDKDA#issuecomment-581448972">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRJPXISZL6R3RZILYLRBAVARANCNFSM4KPBWZRQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXMOA273TZTU2PDSTDRBAVARA5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUDKDA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3933?email_source=notifications\u0026email_token=AJFFTNQSJZ6NHV5ELDRSUQTRBAVARA5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUDKDA#issuecomment-581448972",
"url": "https://github.com/bisq-network/bisq/pull/3933?email_source=notifications\u0026email_token=AJFFTNQSJZ6NHV5ELDRSUQTRBAVARA5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUDKDA#issuecomment-581448972",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>