<p><b>@sqrrm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3933#discussion_r374262419">core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java</a>:</p>
<pre style='color:#555'>> @@ -217,7 +218,7 @@ public static TradeStatistics2 fromProto(protobuf.TradeStatistics2 proto) {
                 proto.getTradePrice(),
                 proto.getTradeAmount(),
                 proto.getTradeDate(),
-                null, // We don't want to expose this anymore
+                ProtoUtil.stringOrNullFromProto(proto.getDepositTxId()),
</pre>
<p>This would leave all new trades from older clients still exposed. That's perhaps the safest way to do it. Was hoping it would be possible to keep setting it to null for new version and just not serve the old version anything. Not sure if that would break things though.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3933?email_source=notifications&email_token=AJFFTNUVAULSFJPEWFRQB5TRBBOJBA5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUBCPTQ#pullrequestreview-352462798">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRMEVNYM4XFNSRKKPTRBBOJBANCNFSM4KPBWZRQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTB7CHRSBSD2FMK2EDRBBOJBA5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUBCPTQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3933?email_source=notifications\u0026email_token=AJFFTNUVAULSFJPEWFRQB5TRBBOJBA5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUBCPTQ#pullrequestreview-352462798",
"url": "https://github.com/bisq-network/bisq/pull/3933?email_source=notifications\u0026email_token=AJFFTNUVAULSFJPEWFRQB5TRBBOJBA5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUBCPTQ#pullrequestreview-352462798",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>