<p><b>@ripcurlx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3933#discussion_r374570236">core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java</a>:</p>
<pre style='color:#555'>> @@ -217,7 +218,7 @@ public static TradeStatistics2 fromProto(protobuf.TradeStatistics2 proto) {
                 proto.getTradePrice(),
                 proto.getTradeAmount(),
                 proto.getTradeDate(),
-                null, // We don't want to expose this anymore
+                ProtoUtil.stringOrNullFromProto(proto.getDepositTxId()),
</pre>
<p>Yes, you only get the additionally privacy if you update or if you trade with a peer that has already updated. I had to do it like that to prevent the unnecessary load from old clients.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3933?email_source=notifications&email_token=AJFFTNWWRGZM2AYZE5W4IQTRBE3D7A5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUD7TRA#discussion_r374570236">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUBHZJMBXXL77D5SCLRBE3D7ANCNFSM4KPBWZRQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRMZ7XLOBISJ3DDRP3RBE3D7A5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUD7TRA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3933?email_source=notifications\u0026email_token=AJFFTNWWRGZM2AYZE5W4IQTRBE3D7A5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUD7TRA#discussion_r374570236",
"url": "https://github.com/bisq-network/bisq/pull/3933?email_source=notifications\u0026email_token=AJFFTNWWRGZM2AYZE5W4IQTRBE3D7A5CNFSM4KPBWZR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUD7TRA#discussion_r374570236",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>