<p><b>@sqrrm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3958#discussion_r377034921">core/src/main/java/bisq/core/trade/statistics/TradeStatisticsManager.java</a>:</p>
<pre style='color:#555'>> @@ -150,4 +154,30 @@ private void dump() {
             jsonFileManager.writeToDisc(Utilities.objectToJson(array), "trade_statistics");
         }
     }
+
+    static class WrapperTradeStatistics2 {
+        private TradeStatistics2 tradeStatistics;
+
+        public WrapperTradeStatistics2(TradeStatistics2 tradeStatistics) {
+
</pre>
⬇️ Suggested change
<pre style="color: #555">-
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3958#discussion_r377036795">core/src/main/java/bisq/core/trade/statistics/TradeStatisticsManager.java</a>:</p>
<pre style='color:#555'>> +        private TradeStatistics2 tradeStatistics;
+
+        public WrapperTradeStatistics2(TradeStatistics2 tradeStatistics) {
+
+            this.tradeStatistics = tradeStatistics;
+        }
+
+        public TradeStatistics2 unwrap() {
+            return this.tradeStatistics;
+        }
+
+        @Override
+        public boolean equals(Object obj) {
+            if (this == obj) return true;
+            if (obj == null || getClass() != obj.getClass()) return false;
+            var wrapper = (WrapperTradeStatistics2) obj;
</pre>
<p>Don't you need a check that obj is actually a <code>WrapperTradeStatistics2</code> here? Could cause an exception otherwise.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3958?email_source=notifications&email_token=AJFFTNVTWBEBTK75D3LN6TTRCFDFTA5CNFSM4KSNDEEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCU3JYJQ#pullrequestreview-355900454">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSEGAF6CXCFS2NBW5TRCFDFTANCNFSM4KSNDEEA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQADXUZJPSRQQ32U5TRCFDFTA5CNFSM4KSNDEEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCU3JYJQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3958?email_source=notifications\u0026email_token=AJFFTNVTWBEBTK75D3LN6TTRCFDFTA5CNFSM4KSNDEEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCU3JYJQ#pullrequestreview-355900454",
"url": "https://github.com/bisq-network/bisq/pull/3958?email_source=notifications\u0026email_token=AJFFTNVTWBEBTK75D3LN6TTRCFDFTA5CNFSM4KSNDEEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCU3JYJQ#pullrequestreview-355900454",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>