<p>This PR still has no SNAPSHOT version set as the hotfix release was based on it. Should be merged shortly before merging v1.2.7</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/3970'>https://github.com/bisq-network/bisq/pull/3970</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Bump version number for v1.2.6</li>
<li>Add signing debug logs</li>
<li>Fix codacy comment</li>
<li>Do some minor cleanup of DisplayUtils</li>
<li>Fix incorrect rounding of BSQ dollar price to whole number</li>
<li>Update translations</li>
<li>Add 2 new btcnodes operated by @wiz</li>
<li>Revert setting of deposit tx id to null</li>
<li>Remove duplicates when delivered from storage</li>
<li>Remove empty line</li>
<li>Fix address regex</li>
<li>Fix btcnode validation regex to handle multiple FQDNs, add tests</li>
<li>Fix wrong executable path for Windows signing</li>
<li>Add test for Liquid Bitcoin and improve error handling</li>
<li>Update bitcoinJ checkpoints file</li>
<li>Update data stores</li>
<li>Allow NullpointerException to be thrown for invalid offers</li>
<li>Allow unrecognized options in config file</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-0">assets/src/main/java/bisq/asset/coins/LiquidBitcoin.java</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-1">assets/src/test/java/bisq/asset/coins/LiquidBitcoinTest.java</a>
(40)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-2">build.gradle</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-3">common/src/main/java/bisq/common/app/Version.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-4">common/src/main/java/bisq/common/config/Config.java</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-5">common/src/test/java/bisq/common/config/ConfigTests.java</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-6">core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java</a>
(62)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-7">core/src/main/java/bisq/core/btc/nodes/BtcNodes.java</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-8">core/src/main/java/bisq/core/offer/OfferForJson.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-9">core/src/main/java/bisq/core/trade/protocol/BuyerAsMakerProtocol.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-10">core/src/main/java/bisq/core/trade/protocol/BuyerAsTakerProtocol.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-11">core/src/main/java/bisq/core/trade/protocol/ProcessModel.java</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-12">core/src/main/java/bisq/core/trade/protocol/SellerAsMakerProtocol.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-13">core/src/main/java/bisq/core/trade/protocol/SellerAsTakerProtocol.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-14">core/src/main/java/bisq/core/trade/protocol/tasks/PublishTradeStatistics.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-15">core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-16">core/src/main/java/bisq/core/trade/statistics/TradeStatisticsManager.java</a>
(29)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-17">core/src/main/resources/i18n/displayStrings.properties</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-18">core/src/main/resources/i18n/displayStrings_de.properties</a>
(36)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-19">core/src/main/resources/i18n/displayStrings_es.properties</a>
(52)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-20">core/src/main/resources/i18n/displayStrings_fa.properties</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-21">core/src/main/resources/i18n/displayStrings_fr.properties</a>
(88)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-22">core/src/main/resources/i18n/displayStrings_ja.properties</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-23">core/src/main/resources/i18n/displayStrings_pt-br.properties</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-24">core/src/main/resources/i18n/displayStrings_pt.properties</a>
(138)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-25">core/src/main/resources/i18n/displayStrings_ru.properties</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-26">core/src/main/resources/i18n/displayStrings_th.properties</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-27">core/src/main/resources/i18n/displayStrings_vi.properties</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-28">core/src/main/resources/i18n/displayStrings_zh-hans.properties</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-29">core/src/main/resources/i18n/displayStrings_zh-hant.properties</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-30">core/src/main/resources/wallet/checkpoints.txt</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-31">desktop/package/linux/Dockerfile</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-32">desktop/package/linux/package.sh</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-33">desktop/package/linux/release.sh</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-34">desktop/package/macosx/Info.plist</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-35">desktop/package/macosx/create_app.sh</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-36">desktop/package/macosx/finalize.sh</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-37">desktop/package/macosx/replace_version_number.sh</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-38">desktop/package/windows/package.bat</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-39">desktop/package/windows/release.bat</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-40">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-41">desktop/src/main/java/bisq/desktop/util/DisplayUtils.java</a>
(55)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-42">desktop/src/main/java/bisq/desktop/util/GUIUtil.java</a>
(32)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-43">desktop/src/test/java/bisq/desktop/util/GUIUtilTest.java</a>
(60)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-44">p2p/src/main/resources/AccountAgeWitnessStore_BTC_MAINNET</a>
(0)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-45">p2p/src/main/resources/DaoStateStore_BTC_MAINNET</a>
(34209)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-46">p2p/src/main/resources/SignedWitnessStore_BTC_MAINNET</a>
(0)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-47">p2p/src/main/resources/TradeStatistics2Store_BTC_MAINNET</a>
(0)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-48">relay/src/main/resources/version.txt</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3970/files#diff-49">seednode/src/main/java/bisq/seednode/SeedNodeMain.java</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/3970.patch'>https://github.com/bisq-network/bisq/pull/3970.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/3970.diff'>https://github.com/bisq-network/bisq/pull/3970.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3970?email_source=notifications&email_token=AJFFTNQ7ZWWVGU5JPXZ7ZCTRC2CGTA5CNFSM4KVGXQ62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4INRSUZQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVMUHU52U4V2KQWY4TRC2CGTANCNFSM4KVGXQ6Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRZ5CU2L57SRHPA5PLRC2CGTA5CNFSM4KVGXQ62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4INRSUZQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3970?email_source=notifications\u0026email_token=AJFFTNQ7ZWWVGU5JPXZ7ZCTRC2CGTA5CNFSM4KVGXQ62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4INRSUZQ",
"url": "https://github.com/bisq-network/bisq/pull/3970?email_source=notifications\u0026email_token=AJFFTNQ7ZWWVGU5JPXZ7ZCTRC2CGTA5CNFSM4KVGXQ62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4INRSUZQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>