<p><b>@dmos62</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3982#discussion_r380392243">core/src/main/java/bisq/core/user/Preferences.java</a>:</p>
<pre style='color:#555'>>          // unless the useTorForBtc parameter is explicitly provided.
         // On testnet there are very few Bitcoin tor nodes and we don't provide tor nodes.
+
+        // TODO bug. Non-critical, apparently.
+        // Sometimes this method, which queries LocalBitcoinNode for whether or not there's a
+        // usable local Bitcoin node, is called before LocalBitcoinNode has performed its
+        // checks. This was noticed when LocalBitcoinNode was refactored to return
+        // Optional<Boolean> istead of boolean, an empty Optional signifying that the relevant
+        // check has not yet been performed.
+        //
+        // To keep the method's behaviour unchanged, until a fix is implemented, we use
+        // Optional.orElse(false). Here 'false' normally means that the checks were performed
+        // and a suitable local Bitcoin node wasn't found.
+        var usableLocalNodePresent = localBitcoinNode.isUsable().orElse(false);
</pre>
<p>This is the bug I mentioned.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3982?email_source=notifications&email_token=AJFFTNQUGT64UBAB6MB6WITRDMJQVA5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCV2R7CQ#pullrequestreview-359997322">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQTRSMTF2XNOYRKSUTRDMJQVANCNFSM4KWZVT6A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNR6OZ5H5L2YXRVDI73RDMJQVA5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCV2R7CQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3982?email_source=notifications\u0026email_token=AJFFTNQUGT64UBAB6MB6WITRDMJQVA5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCV2R7CQ#pullrequestreview-359997322",
"url": "https://github.com/bisq-network/bisq/pull/3982?email_source=notifications\u0026email_token=AJFFTNQUGT64UBAB6MB6WITRDMJQVA5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCV2R7CQ#pullrequestreview-359997322",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>