<p><b>@dmos62</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3982#discussion_r382846204">core/src/main/java/bisq/core/app/BisqSetup.java</a>:</p>
<pre style='color:#555'>>              nextStep.run();
             return;
         }
 
-        localBitcoinNode.detectAndRun(nextStep);
+        // Results of the check don't have to be passed to nextStep,
+        // because they're cached in LocalBitcoinNode and dependent routines query it themselves.
+        localBitcoinNode.checkUsable();
+
+        // Here we only want to provide the user with a choice (in a popup) in case a local node is
+        // detected, but badly configured.
+        var detectedButMisconfigured = localBitcoinNode.isDetectedButMisconfigured().get();
</pre>
<p>I took your suggestion about getting rid of most of the Optional.get()s in other places, but in my opinion here a check would be superfluous, because it's easy to see that getting an empty Optional is impossible here with the current implementation of LocalBitcoinNode (<code>.checkUsable()</code> on the previous line guarantees that). That said if it were to change, all the calls would have to be reconsidered anyway, right?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3982?email_source=notifications&email_token=AJFFTNRLQZIVI47N5G3Q7HLREBMK3A5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRHBQQ#discussion_r382846204">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQ5F3T4HITQ7NP346TREBMK3ANCNFSM4KWZVT6A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVSIBWSA64JK7XB6WTREBMK3A5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRHBQQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3982?email_source=notifications\u0026email_token=AJFFTNRLQZIVI47N5G3Q7HLREBMK3A5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRHBQQ#discussion_r382846204",
"url": "https://github.com/bisq-network/bisq/pull/3982?email_source=notifications\u0026email_token=AJFFTNRLQZIVI47N5G3Q7HLREBMK3A5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRHBQQ#discussion_r382846204",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>