<p><b>@sqrrm</b> approved this pull request.</p>
<p>utACK</p>
<p>I will test this before merging. <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/dmos62/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/dmos62">@dmos62</a> if you feel like removing some of the extra empty lines in some of the methods meanwhile, please don't hesitate. I find the code harder to read with too much space as it breaks the flow compared with the other parts of the project.</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3982#discussion_r382927372">core/src/main/java/bisq/core/btc/nodes/LocalBitcoinNode.java</a>:</p>
<pre style='color:#555'>> +
+ /**
+ * Method backported from upstream bitcoinj: at the time of writing, our version is
+ * not BIP111-aware.
+ * Source routines and data can be found in Bitcoinj under:
+ * core/src/main/java/org/bitcoinj/core/VersionMessage.java
+ * and
+ * core/src/main/java/org/bitcoinj/core/NetworkParameters.java
+ */
+
+ private static boolean isBloomFilteringSupportedAndEnabled(VersionMessage versionMessage) {
+ // A service bit that denotes whether the peer supports BIP37 bloom filters or not.
+ // The service bit is defined in BIP111.
+ int NODE_BLOOM = 1 << 2;
+
+ int BLOOM_FILTERS_BIP37_PROTOCOL_VERSION = 70000;
</pre>
<p>In my opinion this kind of containment is good. Camel case local variables would not be appropriate, but making them local seems right considering the situation.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3982?email_source=notifications&email_token=AJFFTNQADVIW5SVP6KCMQGTREFNKXA5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRY2BA#pullrequestreview-363040004">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNS73DYVTP4PGDEGNL3REFNKXANCNFSM4KWZVT6A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNT4BIKWPDKWK63GEOLREFNKXA5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRY2BA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3982?email_source=notifications\u0026email_token=AJFFTNQADVIW5SVP6KCMQGTREFNKXA5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRY2BA#pullrequestreview-363040004",
"url": "https://github.com/bisq-network/bisq/pull/3982?email_source=notifications\u0026email_token=AJFFTNQADVIW5SVP6KCMQGTREFNKXA5CNFSM4KWZVT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRY2BA#pullrequestreview-363040004",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>