<p><b>@freimair</b> commented on this pull request.</p>

<p>NACK</p>
<ul>
<li>the config for the JVM heap monitoring has been changed so that it constantly creates errors for pricenodes (because the jmxremote-access point is not configured)</li>
<li>see comment for line 55</li>
<li></li>
</ul><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3997#discussion_r382905888">monitor/install_collectd_debian.sh</a>:</p>
<pre style='color:#555'>> -sudo -H -i -u "${ROOT_USER}" systemctl restart bisq.service
+set +e
</pre>
<p>this lets errors slip through and leave operators in the believe that everything is fine.</p>
<p>Something like this may do it. I am pretty sure though that if I really want to break it I still can.</p>
<pre><code>set +e
service bisq status >/dev/null 2>&1
[ $? != 4 ] && set -e && sudo -H -i -u "${ROOT_USER}" systemctl restart bisq.service
set +e
service bisq-pricenode status >/dev/null 2>&1
[ $? != 4 ] && set -e && sudo -H -i -u "${ROOT_USER}" systemctl restart bisq-pricenode.service
set -e
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3997?email_source=notifications&email_token=AJFFTNUNKRRORG26OEKSXIDREEDXVA5CNFSM4KZB4VH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRU57A#pullrequestreview-363024124">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQMLGX7JQPAYJZDRL3REEDXVANCNFSM4KZB4VHQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWO7VMVQIFDIAS4S2DREEDXVA5CNFSM4KZB4VH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRU57A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3997?email_source=notifications\u0026email_token=AJFFTNUNKRRORG26OEKSXIDREEDXVA5CNFSM4KZB4VH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRU57A#pullrequestreview-363024124",
"url": "https://github.com/bisq-network/bisq/pull/3997?email_source=notifications\u0026email_token=AJFFTNUNKRRORG26OEKSXIDREEDXVA5CNFSM4KZB4VH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWRU57A#pullrequestreview-363024124",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>