<p>Previously, Config#mkdir and #mkAppDir threw ConfigException if any<br>
underlying IOException was thrown from Files#createDirectory or<br>
Files#createDirectories respectively. This resulted in only a simple<br>
error message being reported at the command line and the details of the<br>
underlying exception's stack trace were lost. This change wraps and<br>
rethrows the underlying IOException as an UncheckedIOException such that<br>
it gets caught by the catch(Throwable) clause in BisqExecutable, which<br>
does print a stacktrace to stderr. This is the way it always should have<br>
worked; throwing ConfigException in these cases was an oversight in the<br>
original implementation. This change also removes the ConfigException<br>
constructor that allows for passing a nested exception to be wrapped as<br>
there is actually no use case for this now that these two anomalies have<br>
been corrected.</p>
<p>Note to maintainers: while this change was made in the process of attempting to reproduce <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="569034812" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3998" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/3998/hovercard" href="https://github.com/bisq-network/bisq/issues/3998">#3998</a>, it should be merged in any case, independent of the resolution of that bug.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4002'>https://github.com/bisq-network/bisq/pull/4002</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Throw UncheckedIOException on directory creation errors</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4002/files#diff-0">common/src/main/java/bisq/common/config/Config.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4002/files#diff-1">common/src/main/java/bisq/common/config/ConfigException.java</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4002.patch'>https://github.com/bisq-network/bisq/pull/4002.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4002.diff'>https://github.com/bisq-network/bisq/pull/4002.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4002?email_source=notifications&email_token=AJFFTNQZ457Y7DBYIIBKFT3REOPBRA5CNFSM4K2FP4VKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPV6ELQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQBXEY2IQBVCMRFVJDREOPBRANCNFSM4K2FP4VA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRFXJKK3BRFET6RMJTREOPBRA5CNFSM4K2FP4VKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPV6ELQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4002?email_source=notifications\u0026email_token=AJFFTNQZ457Y7DBYIIBKFT3REOPBRA5CNFSM4K2FP4VKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPV6ELQ",
"url": "https://github.com/bisq-network/bisq/pull/4002?email_source=notifications\u0026email_token=AJFFTNQZ457Y7DBYIIBKFT3REOPBRA5CNFSM4K2FP4VKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPV6ELQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>