<p>Thanks for the list.<br>
Regarding <code>VoteWithProposalTxIdList</code> and <code>MeritList</code>: Yes I also assume there is not issue but I think its more safe to use a dedicated class to avoid potential future issues. Those classed implement also the <code>ConsensusCritical</code> which marks classed critical to consensus.</p>
<p>Also the <code>PersistableNetworkPayloadList</code> and its related classes (<code>PersistableNetworkPayloadListService</code>) could be cleaned up and removed (in separate PR). It was long ago used for converting db files.<br>
<code>PersistableHashMap</code> is also not used.</p>
<p>Thanks again for working on that!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4025?email_source=notifications&email_token=AJFFTNUHSV55AUVWYLF3IODRG3Q7NA5CNFSM4LBEPX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONYNMI#issuecomment-597395121">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVOE6XFY6NWIIZAHX3RG3Q7NANCNFSM4LBEPX6Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNU33Z5DZB5CI6RONJTRG3Q7NA5CNFSM4LBEPX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONYNMI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4025?email_source=notifications\u0026email_token=AJFFTNUHSV55AUVWYLF3IODRG3Q7NA5CNFSM4LBEPX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONYNMI#issuecomment-597395121",
"url": "https://github.com/bisq-network/bisq/pull/4025?email_source=notifications\u0026email_token=AJFFTNUHSV55AUVWYLF3IODRG3Q7NA5CNFSM4LBEPX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONYNMI#issuecomment-597395121",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>