<p>Earlier, I (manually) worked out a type hierarchy of everything extending / implementing <code>PersistableEnvelope</code> after the proposed changes:</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/54855381/76367873-53640080-6369-11ea-93e4-944cbb6e46f9.png"><img src="https://user-images.githubusercontent.com/54855381/76367873-53640080-6369-11ea-93e4-944cbb6e46f9.png" alt="Screenshot from 2020-03-11 07-23-24" style="max-width:100%;"></a><br>
(Actuallty <code>PersistableList</code> isn't an abstract class, but probably could be.)</p>
<p>I was intending to clean up the classes incorrectly implementing <code>PersistableEnvelope</code> in a separate PR, as suggested.</p>
<p>It looks like every <code>toProtoMessage</code> and <code>fromProto</code> method of each class in the DAO package extending <code>PersistableList</code> collects items into a new list using a stream, anyway, when mapping the input list items to/from <em>proto.*</em> objects. So I would have thought that only the iteration order of the <code>PersistableList.getList()</code> items matters for proto conversion.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4025?email_source=notifications&email_token=AJFFTNWMSP2HRKWUWVVX2RDRG3JGVA5CNFSM4LBEPX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONUXLA#issuecomment-597380012">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNV5IUZWTZJL4ECZQ7DRG3JGVANCNFSM4LBEPX6Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVSM37U6KM2VDRKKM3RG3JGVA5CNFSM4LBEPX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONUXLA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4025?email_source=notifications\u0026email_token=AJFFTNWMSP2HRKWUWVVX2RDRG3JGVA5CNFSM4LBEPX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONUXLA#issuecomment-597380012",
"url": "https://github.com/bisq-network/bisq/pull/4025?email_source=notifications\u0026email_token=AJFFTNWMSP2HRKWUWVVX2RDRG3JGVA5CNFSM4LBEPX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONUXLA#issuecomment-597380012",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>