<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #3990.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="567301350" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/3990" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/3990/hovercard" href="https://github.com/bisq-network/bisq/issues/3990">#3990</a></p>
<p>Currently bisq desktop does not accept IPv6 addresses in the settings for custom nodes or via the <code>--btcNodes</code> command line option.<br>
While the address format is already validated in <code>desktop / GUIUtil</code>, the separation of address and port is handled incorrectly in <code>core / BtcNodes::fromFullAddress</code>.<br>
This results in IPv6 addresses being ignored, regardless of whether they are entered via the GUI or command line.</p>
<p>This change fixes the code in <code>BtcNodes::fromFullAddress</code> to identify an IPv6 address as being surrounded by square brackets.</p>
<ul>
<li>IPv6 addresses are a sequence of hexadecimal and ':' characters enclosed by square brackets, followed by an optional colon and port number</li>
<li>Onion addresses are a sequence of alphanumeric characters followed by <code>.onion</code> and an optional colon and port number</li>
<li>IPv4 addresses are a sequence of numeric and '.' characters followed by an optional colon and port number</li>
</ul>
<p><strong>Testing</strong>:<br>
the following use case tests were identified and checked:</p>
<ul>
<li>onion address no port</li>
<li>onion address with port</li>
<li>IPv4 address no port</li>
<li>IPv4 address with port</li>
<li>IPv6 address no port</li>
<li>IPv6 address with port</li>
<li>combination of all the above types</li>
<li>invalid input</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4045'>https://github.com/bisq-network/bisq/pull/4045</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>fix #3990</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4045/files#diff-8daba3bb674e0f3332b84cc4b32cd7a6">core/src/main/java/bisq/core/btc/nodes/BtcNodes.java</a>
    (25)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4045.patch'>https://github.com/bisq-network/bisq/pull/4045.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4045.diff'>https://github.com/bisq-network/bisq/pull/4045.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4045?email_source=notifications&email_token=AJFFTNQKFEICSB7H3FMHO53RG4EWFA5CNFSM4LFNBOFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IUCYRLQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUJEVKPOR5DV46J7U3RG4EWFANCNFSM4LFNBOFA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTDYSPHG6DPDV2C5X3RG4EWFA5CNFSM4LFNBOFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IUCYRLQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4045?email_source=notifications\u0026email_token=AJFFTNQKFEICSB7H3FMHO53RG4EWFA5CNFSM4LFNBOFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IUCYRLQ",
"url": "https://github.com/bisq-network/bisq/pull/4045?email_source=notifications\u0026email_token=AJFFTNQKFEICSB7H3FMHO53RG4EWFA5CNFSM4LFNBOFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IUCYRLQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>