<p>Use <code>excludeFromJsonDataMap</code> to add an optional owner full name property to Faster Payments (GBP) accounts, without affecting the trade JSON contract (for backwards compatibility). This is to <span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #3976.">fix</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="566212255" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/3976" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/3976/hovercard" href="https://github.com/bisq-network/bisq/issues/3976">#3976</a>, that some banks have started checking the recipient name.</p>
<p>Make the name a non-optional field for <em>new</em> accounts, but display the details for old Faster Payments accounts in exactly the same way as before, only showing the extra field in the info popup, account and trade step views when it is present.</p>
<p>Also update the now misleading payment instructions in the buyer popup.</p>
<p>--</p>
<p>TODO: Update/remove non-English translations (which probably aren't needed).</p>
<p>TODO: Add a popup to instruct old Faster Payments account holders to (carefully) recreate their account, before opening the create/take offer view.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/4046'>https://github.com/bisq-network/bisq/pull/4046</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Remove redundant @Nullable from account payload excludeFromJsonDataMap</li>
<li>Add holder name for new Faster Payments accounts</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-68e7c4b11777e1e8434d62057a285d1d">core/src/main/java/bisq/core/payment/FasterPaymentsAccount.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-610ce6928e51994a8a8e0080afe5bc68">core/src/main/java/bisq/core/payment/payload/AdvancedCashAccountPayload.java</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-93978ab03e2ce9f4799eeb2b8e000f14">core/src/main/java/bisq/core/payment/payload/AliPayAccountPayload.java</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-a6a7c28967ccb3735415ef4a68325664">core/src/main/java/bisq/core/payment/payload/AssetsAccountPayload.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-144ad3244676dbef4cb51fdd4d774336">core/src/main/java/bisq/core/payment/payload/BankAccountPayload.java</a>
(23)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-4ceff976e1fa83178b363d331467ae08">core/src/main/java/bisq/core/payment/payload/CashAppAccountPayload.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-0b4e2a9ad52130107aa7b44345ad707d">core/src/main/java/bisq/core/payment/payload/CashDepositAccountPayload.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-68f0c55ef0baedbc25f13f34b87246b1">core/src/main/java/bisq/core/payment/payload/ChaseQuickPayAccountPayload.java</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-520d0e4b57b67829c3f8b179b63f6475">core/src/main/java/bisq/core/payment/payload/ClearXchangeAccountPayload.java</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-85ab48cefce98d35163bbdaeaf6cdd86">core/src/main/java/bisq/core/payment/payload/CountryBasedPaymentAccountPayload.java</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-c2b6acb66d60f138b3fb992bf22e98d2">core/src/main/java/bisq/core/payment/payload/CryptoCurrencyAccountPayload.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-be1f64920ea0cfa981ac5d547cb6c2b8">core/src/main/java/bisq/core/payment/payload/F2FAccountPayload.java</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-f2b5f896ae1e131ce5df1c81f385558c">core/src/main/java/bisq/core/payment/payload/FasterPaymentsAccountPayload.java</a>
(29)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-95763888da37ba5045d2704c90adc219">core/src/main/java/bisq/core/payment/payload/HalCashAccountPayload.java</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-e007fac22c7f3cbb65fb54d01eeb7140">core/src/main/java/bisq/core/payment/payload/InstantCryptoCurrencyPayload.java</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-f3e6c4c603fc150fff26838f2d71e662">core/src/main/java/bisq/core/payment/payload/InteracETransferAccountPayload.java</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-2988600adf3bd91e1555cc65b480bb8b">core/src/main/java/bisq/core/payment/payload/JapanBankAccountPayload.java</a>
(56)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-39a9ab6811522604a36763e270ea974d">core/src/main/java/bisq/core/payment/payload/MoneyBeamAccountPayload.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-64d3a35c235cff605712ef48fc71061f">core/src/main/java/bisq/core/payment/payload/MoneyGramAccountPayload.java</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-9c0f845df9fda99e7f7e9d2e864cd11e">core/src/main/java/bisq/core/payment/payload/NationalBankAccountPayload.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-8cba2a34a351ef92e227c2c1255aaa51">core/src/main/java/bisq/core/payment/payload/OKPayAccountPayload.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-fa735d5f3bdf5a6ce737188d7c8a8dfc">core/src/main/java/bisq/core/payment/payload/PaymentAccountPayload.java</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-b1938099538799bcbf0baec2288e84a9">core/src/main/java/bisq/core/payment/payload/PerfectMoneyAccountPayload.java</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-20ebb6057d446d04390b21e47bc372ab">core/src/main/java/bisq/core/payment/payload/PopmoneyAccountPayload.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-afe3ef64f1ff1a1bdada1cc5ecddd14f">core/src/main/java/bisq/core/payment/payload/PromptPayAccountPayload.java</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-5ed2b63cf6c49606094e30067768aafc">core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-f37b950e38ba38ce1f737fe21206f57a">core/src/main/java/bisq/core/payment/payload/SameBankAccountPayload.java</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-68533fa1ace590799563fbbcf8216182">core/src/main/java/bisq/core/payment/payload/SepaAccountPayload.java</a>
(30)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-a074f9824a2af5b8af10b061b7c1c236">core/src/main/java/bisq/core/payment/payload/SepaInstantAccountPayload.java</a>
(25)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-76fc916f8ed4f2d02688ebd3aa094542">core/src/main/java/bisq/core/payment/payload/SpecificBanksAccountPayload.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-e63982b8cff47e15b59a3d9504101a77">core/src/main/java/bisq/core/payment/payload/SwishAccountPayload.java</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-6b2f9069541b03dff195686381cadd0a">core/src/main/java/bisq/core/payment/payload/USPostalMoneyOrderAccountPayload.java</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-186b3195e22739564e8acd2474dc35e5">core/src/main/java/bisq/core/payment/payload/UpholdAccountPayload.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-47be6c9235e25736eef8457734bde387">core/src/main/java/bisq/core/payment/payload/VenmoAccountPayload.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-92f1b38d1bb53b2cba42223484b9bce7">core/src/main/java/bisq/core/payment/payload/WeChatPayAccountPayload.java</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-6e42a45b0de3418d1c248753c93966a5">core/src/main/java/bisq/core/payment/payload/WesternUnionAccountPayload.java</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-2b16c2ca0e92ce28cd7268b07a143647">core/src/main/resources/i18n/displayStrings.properties</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4046/files#diff-6f803e68106e2e112dcfea4603a639d3">desktop/src/main/java/bisq/desktop/components/paymentmethods/FasterPaymentsForm.java</a>
(25)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/4046.patch'>https://github.com/bisq-network/bisq/pull/4046.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/4046.diff'>https://github.com/bisq-network/bisq/pull/4046.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4046?email_source=notifications&email_token=AJFFTNUCQRNBMWPCE7LLGI3RG52LPA5CNFSM4LFT2PJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IUF53SQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXAI4XVU2XXRABKS53RG52LPANCNFSM4LFT2PJA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTP2SET3KKMSQJKGDDRG52LPA5CNFSM4LFT2PJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IUF53SQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4046?email_source=notifications\u0026email_token=AJFFTNUCQRNBMWPCE7LLGI3RG52LPA5CNFSM4LFT2PJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IUF53SQ",
"url": "https://github.com/bisq-network/bisq/pull/4046?email_source=notifications\u0026email_token=AJFFTNUCQRNBMWPCE7LLGI3RG52LPA5CNFSM4LFT2PJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IUF53SQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>