<p></p>
<p><b>@ripcurlx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4068#discussion_r393769016">desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java</a>:</p>
<pre style='color:#555'>> +            if (newValue==TableColumn.SortType.DESCENDING)
+                amountColumn.setComparator(Comparator.comparing(o -> o.getOffer().getAmount(), Comparator.nullsFirst(Comparator.naturalOrder())));
+            else
+                amountColumn.setComparator(Comparator.comparing(o -> o.getOffer().getMinAmount(), Comparator.nullsFirst(Comparator.naturalOrder())));
+        });
+        volumeColumn.sortTypeProperty().addListener((observable, oldValue, newValue) -> {
+            if (newValue==TableColumn.SortType.DESCENDING)
+                volumeColumn.setComparator(Comparator.comparing(o -> o.getOffer().getVolume(), Comparator.nullsFirst(Comparator.naturalOrder())));
+            else
+                volumeColumn.setComparator(Comparator.comparing(o -> o.getOffer().getMinVolume(), Comparator.nullsFirst(Comparator.naturalOrder())));
+        });
</pre>
<p>As we had issues in the past concerning using no brackets for one line conditionals we decided to use always <code>{}</code></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4068#pullrequestreview-376150295">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXDZSQ3MAOGQVIEOFTRH6KFDANCNFSM4LMIMOOA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQKFDYDQUSB64VV6GDRH6KFDA5CNFSM4LMIMOOKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCZVZSFY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4068#pullrequestreview-376150295",
"url": "https://github.com/bisq-network/bisq/pull/4068#pullrequestreview-376150295",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>