<p></p>
<p>I've just made another commit to remove the <code>UserThreadMappedPersistableEnvelope</code> interface from the two classes, as recommended by <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ManfredKarrer/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ManfredKarrer">@ManfredKarrer</a>. After the change, the interface still lies on all the remaining classes extending <code>PersistableList</code>, where I believe it's actually needed (except possibly <code>PaymentAccountList</code>, which appears to only have a hypothetical race setting <code>paymentAccount.selectedTradeCurrency</code> when using the non-thread-safe persistence interface).</p>
<p>This does, however, include three other <code>ConsensusCritical</code> classes, changing the original behaviour (to fix the bug): <code>MyProposalList</code>, <code>MyBlindVoteList</code> and <code>BallotList</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4025#issuecomment-602169035">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQJKIZGIKPUC277KJDRIXI7BANCNFSM4LBEPX6Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXXCTVSHUNGC6IZOSDRIXI7BA5CNFSM4LBEPX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEPSF5SY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4025#issuecomment-602169035",
"url": "https://github.com/bisq-network/bisq/pull/4025#issuecomment-602169035",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>