<p></p>
<blockquote>
<blockquote>
<p>and, b) this WIP implementation just does peer.close(), which causes the PeerGroup to just retry the connection, in case we're in local mode, or possibly retry later in case we're in non-local mode (didn't explore non-local behaviour yet); I'm pondering if this is indeed undesirable or if we would want to use this to get free auto-retry.</p>
</blockquote>
<p>You mean a retry to the same peer?</p>
</blockquote>
<p>Yes. I didn't double-check, but I think BitcoinJ uses a FILO queue for keeping addresses of nodes. It pops and connects to them until wanted number of connections is established. In case we're in local-mode, then that queue has size 1 and contains localhost.</p>
<blockquote>
<p>block the setup process [when a local bitcoin node is misconfigured] and do it as with your previous implementation to allow the user to shutdown and fix this issue</p>
</blockquote>
<p>I'd be in favor of letting an unclosable error popup be displayed asynchroniously. That would involve less fiddling with the setup process (less likely to break something).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4081#issuecomment-602695925">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXW3FTC565YSDBDEXDRI6CABANCNFSM4LQ7C2TA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSXDTB7NP6X5QNSBQ3RI6CABA5CNFSM4LQ7C2TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEPWGR5I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4081#issuecomment-602695925",
"url": "https://github.com/bisq-network/bisq/pull/4081#issuecomment-602695925",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>