<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/dmos62/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/dmos62">@dmos62</a> Your build is broken right now: <a href="https://travis-ci.org/github/bisq-network/bisq/builds/665235608?utm_source=github_status&utm_medium=notification" rel="nofollow">https://travis-ci.org/github/bisq-network/bisq/builds/665235608?utm_source=github_status&utm_medium=notification</a></p>
<blockquote>
<p>a) connecting to a pruning node, on my setup at least, causes the connection to crash, and the listener never gets triggered; this is a rare BitcoinJ edge case bug and I opened an issue for it <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="585532705" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4080" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/4080/hovercard" href="https://github.com/bisq-network/bisq/issues/4080">#4080</a> ;</p>
</blockquote>
<p>Yes, I get following exception in the logs</p>
<pre><code>März-23 15:46:57.444 [NioClientManager] WARN  o.b.core.PeerSocketHandler: [127.0.0.1]:18444 -  org.bitcoinj.core.ProtocolException: Received AlertMessage before version handshake is complete.
        at org.bitcoinj.core.Peer.processMessage(Peer.java:478)
        at org.bitcoinj.core.PeerSocketHandler.receiveBytes(PeerSocketHandler.java:184)
        at org.bitcoinj.net.ConnectionHandler.handleKey(ConnectionHandler.java:223)
        at org.bitcoinj.net.NioClientManager.handleKey(NioClientManager.java:86)
        at org.bitcoinj.net.NioClientManager.run(NioClientManager.java:122)
        at com.google.common.util.concurrent.AbstractExecutionThreadService$1$2.run(AbstractExecutionThreadService.java:66)
        at com.google.common.util.concurrent.Callables$4.run(Callables.java:122)
        at org.bitcoinj.utils.ContextPropagatingThreadFactory$1.run(ContextPropagatingThreadFactory.java:49)
        at java.base/java.lang.Thread.run(Thread.java:844)
</code></pre>
<blockquote>
<p>and, b) this WIP implementation just does <code>peer.close()</code>, which causes the PeerGroup to just retry the connection, in case we're in local mode, or possibly retry later in case we're in non-local mode (didn't explore non-local behaviour yet); I'm pondering if this is indeed undesirable or if we would want to use this to get free auto-retry.</p>
</blockquote>
<p>You mean a retry to the same peer?</p>
<blockquote>
<p>Another open question is what to do in case a remote node is found to be misconfigured. Just an error log?</p>
</blockquote>
<p>It depends. If it would be a misconfigured provided node/public node I would just ignore it and not connect to it. If it is a node the user has configured by using a config/start parameter I think we should display a warning to the user. Also if it is a misconfigured local node we want to notify the user that something is not correct.</p>
<p>In general if we do this check after the connection I think it should be fine if we block the setup process at that point (e.g. when a local bitcoin node is misconfigured) and do it as with your previous implementation to allow the user to shutdown and fix this issue.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4081#issuecomment-602651836">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRLNLEXCULRU7VGKH3RI52F7ANCNFSM4LQ7C2TA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUFGMTS2H6JIPPHCT3RI52F7A5CNFSM4LQ7C2TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEPV3ZPA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4081#issuecomment-602651836",
"url": "https://github.com/bisq-network/bisq/pull/4081#issuecomment-602651836",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>