<p>This change fixes an issue whereby dust change outputs are inadvertently created during the trading process, unbeknownst to the user.  The dust outputs cause the Bitcoin node to reject the<br>
transaction and the trade then becomes stuck.</p>
<p>The solution taken here is to detect a dust TXO during the trade process and remove it from the transaction before broadcasting.  This applies in both making an offer and/or taking an existing offer.  When a dust output is prevented, it will be noted in the log as follows:</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/77453644-82e12700-6dc5-11ea-83cf-eb2227c6275d.png"><img src="https://user-images.githubusercontent.com/47253594/77453644-82e12700-6dc5-11ea-83cf-eb2227c6275d.png" alt="image" style="max-width:100%;"></a></p>
<p>Related to <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="578316623" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4039" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/4039/hovercard" href="https://github.com/bisq-network/bisq/issues/4039">#4039</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4094'>https://github.com/bisq-network/bisq/pull/4094</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Remove dust outputs created during the trade process</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4094/files#diff-3618457b84b58a5b3f18c15cd10c5310">core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java</a>
    (24)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4094.patch'>https://github.com/bisq-network/bisq/pull/4094.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4094.diff'>https://github.com/bisq-network/bisq/pull/4094.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4094">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNW6G2HGBVIAYDCJGV3RJDQIBANCNFSM4LS2HZMQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNR5HWQMPMN6GNMUWO3RJDQIBA5CNFSM4LS2HZM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IX6UNBA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4094",
"url": "https://github.com/bisq-network/bisq/pull/4094",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>