<p></p>
<p><b>@ripcurlx</b> requested changes on this pull request.</p>

<p>NACK - please see my comment regarding the buyers UI during the trade process.<br>
Also please only commit changes to the English source file all other files will be overwritten automatically by loading translations from Transifex before the next release.</p>
<p>ACK from a functionality perspective. Tested old and new Faster Payment Accounts in trades.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4046#discussion_r398659814">desktop/src/main/java/bisq/desktop/components/paymentmethods/FasterPaymentsForm.java</a>:</p>
<pre style='color:#555'>> +        if (!((FasterPaymentsAccountPayload) paymentAccountPayload).getHolderName().isEmpty()) {
+            addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("payment.account.owner"),
+                    ((FasterPaymentsAccountPayload) paymentAccountPayload).getHolderName());
+        }
</pre>
<p>If this field is shown during the trade process it creates unnecessary scrolling.<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/170962/77663881-d8603400-6f7d-11ea-918c-ed11a5557106.png"><img width="1312" alt="Bildschirmfoto 2020-03-26 um 16 16 33" src="https://user-images.githubusercontent.com/170962/77663881-d8603400-6f7d-11ea-918c-ed11a5557106.png" style="max-width:100%;"></a><br>
I'd just change line 54-55 to</p>
<pre><code>addCompactTopLabelTextField(gridPane, gridRow, 1, Res.get("payment.accountNr"),
                ((FasterPaymentsAccountPayload) paymentAccountPayload).getAccountNr());
</code></pre>
<p>which puts sort code and account nr next to each other.<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/170962/77663992-ff1e6a80-6f7d-11ea-8847-11f72f189964.png"><img width="1312" alt="Bildschirmfoto 2020-03-26 um 16 19 57" src="https://user-images.githubusercontent.com/170962/77663992-ff1e6a80-6f7d-11ea-8847-11f72f189964.png" style="max-width:100%;"></a><br>
That would work for both cases.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4046#pullrequestreview-382120135">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSKFW465DLCUH7QVCLRJNYBTANCNFSM4LFT2PJA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWC6ZYE6FL5X25QVNLRJNYBTA5CNFSM4LFT2PJKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC3DLBRY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4046#pullrequestreview-382120135",
"url": "https://github.com/bisq-network/bisq/pull/4046#pullrequestreview-382120135",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>