<p></p>
<p><b>@cbeams</b> approved this pull request.</p>

<p>ACK, please see my two review commits.</p>
<p>I didn't mention this in the commit comments, but I also removed the FIXMEs from grpc.proto about IDEA complaining about not having references to imported proto definitions from pb.proto. I'm not getting any errors any more, and I can navigate from grpc.proto to pb.proto by clicking, e.g. <code>CMD-B</code> on the imported definition. Find Usages on, e.g. the <code>TradeStatistics2</code> proto def shows its usage in grpc.proto, etc, so I think everything is working as expected. This is probably because of some bug fix in a recent version of the IDEA protobuf plugin.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4096#pullrequestreview-382205277">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSYIZKWP3KGWLCMNYTRJOBR3ANCNFSM4LUHLOEA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXX7JTOL25AF5OZ7LLRJOBR3A5CNFSM4LUHLOEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC3D72XI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4096#pullrequestreview-382205277",
"url": "https://github.com/bisq-network/bisq/pull/4096#pullrequestreview-382205277",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>