<p></p>
<p><b>@cbeams</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4097#discussion_r400004430">cli/src/main/java/bisq/cli/app/BisqCliMain.java</a>:</p>
<pre style='color:#555'>>  
     public static void main(String[] args) {
-        new BisqCliMain("localhost", 8888);
+        new BisqCliMain("localhost", 8888, args);
</pre>
⬇️ Suggested change
<pre style="color: #555">-        new BisqCliMain("localhost", 8888, args);
+        new BisqCliMain("localhost", 9998, args);
</pre>

<p>8888 is a poor number as it's frequently used by other services. 9998 fits with bisq's p2p port of 9999 and follows suit with bitcoind's 8333 p2p port and 8332 rpc port. I realize you did not introduce this change and that it's somewhat out of scope for this PR, but please make it anyway.</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/freimair/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/freimair">@freimair</a>, please note that the choice of 9998 here overlaps with the same port used in <code>monitor/src/main/java/bisq/monitor/metric/TorHiddenServiceStartupTime.java</code>. Please consider changing that to something else if you see it being a conflict.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4097#pullrequestreview-383622456">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQ4C26YSQJ4IY6BTMDRKBIJNANCNFSM4LVDCNHQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUZ7J3CSVEZZ6JTXJ3RKBIJNA5CNFSM4LVDCNH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC3OZ2OA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4097#pullrequestreview-383622456",
"url": "https://github.com/bisq-network/bisq/pull/4097#pullrequestreview-383622456",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>