<p>Dependant PR: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="585535305" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4081" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4081/hovercard" href="https://github.com/bisq-network/bisq/pull/4081">bisq-network/bisq#4081</a></p>
<p>Commit message for commit titled "Add listener for when a VersionMessage is received" explaining the purpose of this commit and the PR in general:</p>
<pre><code>Since Bisq requires nodes with specific configuration (as reflected in
their version messages), we also want to handle misconfigured nodes,
especially in cases where the user expects that node to be used. To get
access to all received version messages, a new listener is introduced.
Existing listeners are not sufficient, because in some cases BitcoinJ
will kill the Peer (connection to a node) before any of them are
triggered. This listener will always be triggered when a VersionMessage
is received.
</code></pre>
<p>In total, this PR introduces a bugfix (Permit alerts during handshake, see <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="585532705" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4080" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/4080/hovercard" href="https://github.com/bisq-network/bisq/issues/4080">bisq-network/bisq#4080</a>), a compilation breaking fix (Fix javadoc compilation on JDK 11), a new listener (Add listener for when a VersionMessage is received) and bumps the version number (<code>0.14.7.bisq.1-SNAPSHOT</code> -> <code>0.14.7.bisq.2-SNAPSHOT</code>).</p>
<p>It should be noted that there is a failing test (not resulting from this PR): <code>ChannelConnectionTest.testChannelResume:459->roundTripClientWallet:551 » IllegalState</code>.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bitcoinj/pull/35'>https://github.com/bisq-network/bitcoinj/pull/35</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Permit alerts during handshake</li>
  <li>Fix javadoc compilation on JDK 11</li>
  <li>Add listener for when a VersionMessage is received</li>
  <li>Bump version number</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bitcoinj/pull/35/files#diff-357e4854869b2e21c38b1b437f11095a">core/pom.xml</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bitcoinj/pull/35/files#diff-521df40d8b947ec2e767e5bb276164a0">core/src/main/java/org/bitcoinj/core/Peer.java</a>
    (34)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bitcoinj/pull/35/files#diff-ffa1ba18e6074748d485cd4d0a8abe6b">core/src/main/java/org/bitcoinj/core/PeerGroup.java</a>
    (73)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bitcoinj/pull/35/files#diff-ac354c1e0c4f4ba65d2fc3fe77dfa41e">core/src/main/java/org/bitcoinj/core/VersionMessage.java</a>
    (10)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bitcoinj/pull/35/files#diff-0caf48e1a6c03852768c9d5c70d3debc">core/src/main/java/org/bitcoinj/core/listeners/VersionMessageReceivedEventListener.java</a>
    (34)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bitcoinj/pull/35/files#diff-08740066c64337d38cccd84991ac0912">examples/pom.xml</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bitcoinj/pull/35/files#diff-600376dffeb79835ede4a0b285078036">pom.xml</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bitcoinj/pull/35/files#diff-249b058c0a0bba5bad380ad23a573c4c">tools/pom.xml</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bitcoinj/pull/35.patch'>https://github.com/bisq-network/bitcoinj/pull/35.patch</a></li>
  <li><a href='https://github.com/bisq-network/bitcoinj/pull/35.diff'>https://github.com/bisq-network/bitcoinj/pull/35.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bitcoinj/pull/35">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQLSSTUYFVZ6UA2VW3RKCPIFANCNFSM4LWTFP6A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTDRHJ7I2NXN6LY4NTRKCPIFA5CNFSM4LWTFP6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IZPLJKA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bitcoinj/pull/35",
"url": "https://github.com/bisq-network/bitcoinj/pull/35",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>