<p></p>
<p>stejbac:</p>
<blockquote>
<p>I don't think <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="575346360" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4025" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4025/hovercard" href="https://github.com/bisq-network/bisq/pull/4025">#4025</a> would affect the hotspot in the screenshot, as it makes no important change to the way SequenceNumberMap is serialised from FileManager. I think that class (like a number of others implementing PersistableEnvelope) already had thread-safe proto conversion, as it just had a single ConcurrentHashMap field. So I didn't force it to run in the user thread. The majority of classes implementing PersistableEnvelope were made to do proto conversion (during persistence) in the user thread, but I'm fairly sure that wouldn't help performance - it might make it harder to spot in the JProfiler views though. It looks like the JProfiler run in the screenshot was in full instrumentation mode - I'm not sure it that might be affecting the apparent hotspot at all, but when I profiled the same area of the code in sampling mode the hotspot seemed to be coming from the sync method call rather than proto conversion.</p>
</blockquote>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/4003#issuecomment-608344825">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUYDGQL4CLELCYCWFTRKWXB5ANCNFSM4K2ISPGQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVJ7YSQCOHTRWGTH6LRKWXB5A5CNFSM4K2ISPG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOERBJV6I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/4003#issuecomment-608344825",
"url": "https://github.com/bisq-network/bisq/issues/4003#issuecomment-608344825",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>