<p>This is another refactoring PR to continue from the work in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="575346360" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4025" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4025/hovercard" href="https://github.com/bisq-network/bisq/pull/4025">#4025</a>, by removing <code>PersistableNetworkPayloadList</code> as suggested in the review. This together with <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="590390686" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4102" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4102/hovercard" href="https://github.com/bisq-network/bisq/pull/4102">#4102</a> removes all the remaining unnecessary <code>PersistableEnvelope</code> implementations.</p>
<p>This class is dead code, together with its store service, as they were only referenced from <code>CorePersistenceProtoResolver::fromProto</code>, the binding logic and from <code>AppendOnlyDataStoreService</code> by orphaned migration code. However, migration from the old persisted data was completed long ago and the store file is no longer being read or written from anywhere in the codebase.</p>
<p>Also remove its associated <code>PersistableEnvelope</code> proto message type, along with the <code>TradeStatisticsList</code> message type. The latter is long deprecated and has no corresponding Java class implementing <code>PersistableEnvelope</code>, so removing it won't change behaviour (outside the exception message thrown when attempting to resolve it).</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4159'>https://github.com/bisq-network/bisq/pull/4159</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Remove PersistableNetworkPayloadList & TradeStatisticsList</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4159/files#diff-7797e84941bbe8ab1a6abf8eac281d85">core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4159/files#diff-a007dfe036304f85c5cb5351107cb8c9">p2p/src/main/java/bisq/network/p2p/P2PModule.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4159/files#diff-7e8e9d59ce010f6263fb6b7ed6682447">p2p/src/main/java/bisq/network/p2p/storage/persistence/AppendOnlyDataStoreService.java</a>
    (22)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4159/files#diff-e2cef8943779c3836bd613d87132041d">p2p/src/main/java/bisq/network/p2p/storage/persistence/PersistableNetworkPayloadList.java</a>
    (86)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4159/files#diff-739d96c8ce355e5ea658d73113405cd3">p2p/src/main/java/bisq/network/p2p/storage/persistence/PersistableNetworkPayloadListService.java</a>
    (126)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4159/files#diff-f0bdb6345845c721c54d9e8a0fb98bef">p2p/src/test/java/bisq/network/p2p/storage/mocks/AppendOnlyDataStoreServiceFake.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4159/files#diff-41caf249b58a6c497f396da0a67168e4">proto/src/main/proto/pb.proto</a>
    (17)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4159.patch'>https://github.com/bisq-network/bisq/pull/4159.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4159.diff'>https://github.com/bisq-network/bisq/pull/4159.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4159">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQLPTFIZSKQPZSLIYDRMBAE7ANCNFSM4MF6HGZA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNV4DYQL43NICO5FOETRMBAE7A5CNFSM4MF6HGZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4I5IMARA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4159",
"url": "https://github.com/bisq-network/bisq/pull/4159",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>