<p></p>
<h3>Description</h3>
<p>Seems that <code>bisq</code> tries to shut down the <code>tor</code> instance even if it wasn't started.</p>
<h4>Version</h4>
<p><code>1.3.1</code></p>
<h3>Steps to reproduce</h3>
<pre><code>/Applications/Bisq.app/Contents/MacOS/Bisq \
  --torControlUseSafeCookieAuth \
  --torControlPort=9051 \
  --torControlCookieFile=$PWD/tor/control_auth_cookie
</code></pre>
<h3>Expected behaviour</h3>
<p>Bisq shouldn't try stopping the bundled <code>tor</code> if it was instructed to use an external instance.</p>
<h3>Actual behaviour</h3>
<p><code>Bisq</code> always tries to stop <code>tor</code> on shutdown.</p>
<h4>Device or machine</h4>
<p>macOS 10.15.4</p>
<h4>Additional info</h4>
<pre><code>Apr-18 19:38:53.265 [torNetworkNodeShutDown-2113] ERROR b.n.p2p.network.TorNetworkNode: Shutdown torNetworkNode failed with exception: Error reply: Unknown Onion Service id
net.freehaven.tor.control.TorControlError: Error reply: Unknown Onion Service id
        at net.freehaven.tor.control.TorControlConnection.sendAndWaitForResponse(TorControlConnection.java:195)
        at net.freehaven.tor.control.TorControlConnection.destroyHiddenService(TorControlConnection.java:968)
        at org.berndpruenster.netlayer.tor.Tor.unpublishHiddenService(Tor.kt:299)
        at org.berndpruenster.netlayer.tor.ExternalTor.shutdown(ExternalTor.kt:174)
        at bisq.network.p2p.network.TorNetworkNode.lambda$torNetworkNodeShutDown$3(TorNetworkNode.java:189)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:514)
        at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)
        at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)
        at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:844)
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/4181">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWKFX6U4YLJ2KXACJ3RNGOO3ANCNFSM4MLK3EMQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNW7WQRFPC3WKZYSDQTRNGOO3A5CNFSM4MLK3EM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4I7IWM2A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/4181",
"url": "https://github.com/bisq-network/bisq/issues/4181",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>