<p></p>
<p><b>@cd2357</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4168#discussion_r418464776">desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java</a>:</p>
<pre style='color:#555'>> +        if (reversePrimarySortOrder)
+            primary = primary.reversed();
+
+        return primary.thenComparing(Offer::getAmount);
</pre>
<p>Minor suggestion to ensure orders with higher amounts are displayed first:</p>
⬇️ Suggested change
<pre style="color: #555">-        if (reversePrimarySortOrder)
-            primary = primary.reversed();
-
-        return primary.thenComparing(Offer::getAmount);
+        // 1st comparator: sort by price
+        // - ascending, if showing orders to sellers
+        // - descending, if showing orders to buyers
+        if (reversePrimarySortOrder)
+            primary = primary.reversed();
+
+        // 2nd comparator: sort by amount, in descending order
+        // The goal is to show the more attractive offers at the top
+        // Both buyers and sellers would prefer to see higher amounts first (for orders with the same price)
+        Comparator<Offer> secondary = Comparator.comparing(Offer::getAmount, Comparator.reverseOrder());
+
+        return primary.thenComparing(secondary);
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4168#pullrequestreview-404072150">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSI7JU253UMQ7OMOO3RPKDV5ANCNFSM4MHZK4TQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRAKUBIMWQ5Y54MABDRPKDV5A5CNFSM4MHZK4T2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODAK2NVQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4168#pullrequestreview-404072150",
"url": "https://github.com/bisq-network/bisq/pull/4168#pullrequestreview-404072150",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>