<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ghubstan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ghubstan">@ghubstan</a>, in preparation to more fully review the use of <code>Tuple2</code> and the other things you've asked about above, I've committed <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/39c868f5959679993b5c12691b34a308c94068c5/hovercard" href="https://github.com/bisq-network/bisq/commit/39c868f5959679993b5c12691b34a308c94068c5"><tt>39c868f</tt></a> which refactors the way we're declaring wallet-related grpc services. Have a look, and I'll get back to my review here as soon as I can. In short, I do want to eliminate <code>Tuple2</code> and go with exceptions, but I need to think about it / try things out a bit further myself.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4214#issuecomment-622925627">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWXOMIUMYSXWSP5HJ3RPPRWJANCNFSM4MUIOB4Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQU23PKEXF2EYEK7ELRPPRWJA5CNFSM4MUIOB42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEUQROOY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4214#issuecomment-622925627",
"url": "https://github.com/bisq-network/bisq/pull/4214#issuecomment-622925627",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>