<p></p>
<p><b>@cbeams</b> requested changes on this pull request.</p>

<p>NACK.</p>
<p>We allow users to set a custom withdrawal transaction fee rate because it's their problem if they set it too low and end up queued in the mempool for an extended period.</p>
<p>We do not allow users to set a custom trading transaction fee rate because it creates a problem for their trading counterparty if they set it too low. The whole trade will get held up in such a case, and that's unfair to the counterparty who used the default fee or chose a more reasonable custom value.</p>
<p>Nit: for future PRs, please follow the commit guidelines at <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="319178416" data-permission-text="Title is private" data-url="https://github.com/bisq-network/style/issues/9" data-hovercard-type="issue" data-hovercard-url="/bisq-network/style/issues/9/hovercard" href="https://github.com/bisq-network/style/issues/9">bisq-network/style#9</a>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4231#pullrequestreview-404729904">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQ5YXJGYXRAFQECBGLRPZNQ3ANCNFSM4MYKX6HA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXDFRRWE5LTDDOO27LRPZNQ3A5CNFSM4MYKX6HKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODAP3AMA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4231#pullrequestreview-404729904",
"url": "https://github.com/bisq-network/bisq/pull/4231#pullrequestreview-404729904",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>