<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ghubstan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ghubstan">@ghubstan</a>, have a look at what I've done in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/163061ac757900642b0ce4ccd083e2c172a8fbca/hovercard" href="https://github.com/bisq-network/bisq/commit/163061ac757900642b0ce4ccd083e2c172a8fbca"><tt>163061a</tt></a> to change the return type of <code>CoreWalletService#getAvailableBalance</code> from <code>Tuple2<Long, ApiStatus></code> back to <code>long</code> and  how throwing <code>IllegalStateException</code> is now favored. The status of all <code>StatusRuntimeExceptions</code> is now set to <code>UNKNOWN</code>, as I don't see a requirement at this point for the client to differentiate between different gRPC status codes. We can introduce that later if need be. For now, this approach keeps <code>CoreWalletService</code> completely unaware of gRPC concepts (as if it were really located in <code>bisq.core</code> where we want it to be) and it its methods are left returning values and throwing exceptions in an idiomatic / plain old java fashion.</p>
<p>Could you refactor the remaining methods in <code>CoreWalletService</code> to follow suit? When finished, <code>ApiStatus</code> should be empty and therefore deleted, and there should no longer be any usage of <code>Tuple2</code>. Preferred is to refactor each method in its own commit. Thanks.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4214#issuecomment-623117234">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNR3O2DSWP7XX3JCPXLRPV4S3ANCNFSM4MUIOB4Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUZVN3ZMROST3W3E4LRPV4S3A5CNFSM4MUIOB42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEUSAHMQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4214#issuecomment-623117234",
"url": "https://github.com/bisq-network/bisq/pull/4214#issuecomment-623117234",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>